Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754359Ab2JWKRH (ORCPT ); Tue, 23 Oct 2012 06:17:07 -0400 Received: from cn.fujitsu.com ([222.73.24.84]:5843 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1752375Ab2JWKRE (ORCPT ); Tue, 23 Oct 2012 06:17:04 -0400 X-IronPort-AV: E=Sophos;i="4.80,635,1344182400"; d="scan'208";a="6051966" Message-ID: <50866EBB.2010507@cn.fujitsu.com> Date: Tue, 23 Oct 2012 18:17:31 +0800 From: Miao Xie Reply-To: miaox@cn.fujitsu.com User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0 MIME-Version: 1.0 To: Borislav Petkov , Tang Chen , tony.luck@intel.com, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, laijs@cn.fujitsu.com, wency@cn.fujitsu.com, x86@kernel.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] Replace if statement with WARN_ON_ONCE() in cmci_rediscover(). References: <1350625528-1385-1-git-send-email-tangchen@cn.fujitsu.com> <1350625528-1385-2-git-send-email-tangchen@cn.fujitsu.com> <20121019164045.GE11958@aftab.osrc.amd.com> <5084AB10.7010807@cn.fujitsu.com> <20121022101442.GB8352@liondog.tnic> <50860711.10807@cn.fujitsu.com> <20121023095234.GA22715@liondog.tnic> In-Reply-To: <20121023095234.GA22715@liondog.tnic> X-MIMETrack: Itemize by SMTP Server on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2012/10/23 18:16:31, Serialize by Router on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2012/10/23 18:16:32, Serialize complete at 2012/10/23 18:16:32 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 840 Lines: 26 On tue, 23 Oct 2012 11:52:34 +0200, Borislav Petkov wrote: > On Tue, Oct 23, 2012 at 10:55:13AM +0800, Tang Chen wrote: >> So, how about warn once, and continue: >> if (cpu == dying) { >> WARN_ON_ONCE(cpu == dying); >> continue; >> } >> >> or, use BUG_ON() instead ? > > Let me ask you again, but I want you to think real hard this time: > > "Why do we need to warn? What good would that bring us?" > This function is called after a cpu is offline, in other words, it is impossible that the cpu is still in cpu_online_mask. otherwise there is something wrong in the code. Thanks Miao -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/