Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932365Ab2JWK3g (ORCPT ); Tue, 23 Oct 2012 06:29:36 -0400 Received: from mail-wi0-f178.google.com ([209.85.212.178]:62025 "EHLO mail-wi0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756478Ab2JWK3c (ORCPT ); Tue, 23 Oct 2012 06:29:32 -0400 MIME-Version: 1.0 In-Reply-To: <20121023122312.56b23e1c@skate> References: <1350911580-20307-1-git-send-email-sourav.poddar@ti.com> <20121022155028.GA13791@core.coreip.homeip.net> <508664CA.7000601@ti.com> <20121023100333.GA24418@arwen.pp.htv.fi> <20121023122312.56b23e1c@skate> Date: Tue, 23 Oct 2012 12:29:28 +0200 Message-ID: Subject: Re: [PATCHv2] Input: omap4-keypad: Add pinctrl support From: Linus Walleij To: Thomas Petazzoni , "Rafael J. Wysocki" , Magnus Damm , Paul Mundt Cc: balbi@ti.com, Benoit Cousson , tony@atomide.com, devicetree-discuss@lists.ozlabs.org, Dmitry Torokhov , linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, Sourav Poddar , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Amit Kucheria Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1571 Lines: 42 On Tue, Oct 23, 2012 at 12:23 PM, Thomas Petazzoni wrote: > > On Tue, 23 Oct 2012 13:03:33 +0300, Felipe Balbi wrote: > >> > But it appears that shmobile prefer to get all resources using >> > bus notifiers. >> > >> > So we need to form some kind of consensus ... or live with >> > the fact that different systems do it different ways. Which will >> > explode the day we need to use a driver on two systems, >> > each using the other approach :-) >> >> I much prefer having drivers explicitly manage all their resources, >> which would mean that pinctrl calls need to be done on probe() and, if >> necessary, during suspend()/resume(). >> >> Using bus notifiers for that is quite a hack IMHO. > > Agreed. Just like drivers do their ioremap, request_irq and others, > they should also request their pin resources using the pinctrl API. > Hiding this behind a bus notifier is not nice. So the biggest implementation of the notifier approach to resource handling is the SH clock thing: drivers/base/power/clock_ops.c It's made to be generic but AFAICT only SH is using this. So according to that paradigm most device resources should be handled that way if I understand correctly the basic idea. So let's get Rafael, Paul and Magnus in here to beat us up a bit :-) Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/