Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756331Ab2JWMQt (ORCPT ); Tue, 23 Oct 2012 08:16:49 -0400 Received: from smtp.ctxuk.citrix.com ([62.200.22.115]:43779 "EHLO SMTP.EU.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753850Ab2JWMQs (ORCPT ); Tue, 23 Oct 2012 08:16:48 -0400 X-IronPort-AV: E=Sophos;i="4.80,634,1344211200"; d="scan'208";a="15333182" Date: Tue, 23 Oct 2012 13:16:18 +0100 From: Stefano Stabellini X-X-Sender: sstabellini@kaball.uk.xensource.com To: Yinghai Lu CC: Stefano Stabellini , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Jacob Shin , Tejun Heo , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 06/19] x86, mm: setup page table in top-down In-Reply-To: Message-ID: References: <1350593430-24470-1-git-send-email-yinghai@kernel.org> <1350593430-24470-10-git-send-email-yinghai@kernel.org> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1103 Lines: 35 On Mon, 22 Oct 2012, Yinghai Lu wrote: > On Mon, Oct 22, 2012 at 11:17 AM, Yinghai Lu wrote: > > On Mon, Oct 22, 2012 at 6:19 AM, Stefano Stabellini > > > How about put sth: > > --- > > Xen mmu requires pages from this function should be directly mapped already. > > --- > > > > or you can introduce some doc tag specially that we can out those > > assumption easily? > > I add > > /* Xen requires pages from this function should be directly mapped already */ > > in [PATCH] x86, mm: Add alloc_low_pages(num) > > hope you are happy with that. > It is not bad, but let's just fix the English a bit and give more context: /* Pages returned by this function are already directly mapped. * * Changing that is likely to break Xen, see commit * 279b706bf800b5967037f492dbe4fc5081ad5d0f for more information on the * subject. */ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/