Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932400Ab2JWMsl (ORCPT ); Tue, 23 Oct 2012 08:48:41 -0400 Received: from mail-ee0-f46.google.com ([74.125.83.46]:61582 "EHLO mail-ee0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756764Ab2JWMsk (ORCPT ); Tue, 23 Oct 2012 08:48:40 -0400 MIME-Version: 1.0 In-Reply-To: <20121023090232.GA13027@localhost> References: <508296B4.60508@gmail.com> <20121023085448.GM5635@localhost> <20121023090232.GA13027@localhost> Date: Tue, 23 Oct 2012 14:48:38 +0200 Message-ID: Subject: Re: [PATCH 06/21] ocfs2: drop vmtruncate From: Marco Stornelli To: Marco Stornelli , Linux FS Devel , Mark Fasheh , ocfs2-devel@oss.oracle.com, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1132 Lines: 35 2012/10/23 Joel Becker : > On Tue, Oct 23, 2012 at 10:58:42AM +0200, Marco Stornelli wrote: >> 2012/10/23 Joel Becker : >> > On Sat, Oct 20, 2012 at 02:19:00PM +0200, Marco Stornelli wrote: >> >> Removed vmtruncate >> >> >> >> Signed-off-by: Marco Stornelli >> > >> > Acked-by: Joel Becker >> > >> > Do you want me to pull this, or are you going to send it with your set? >> > >> > Joel >> > >> >> I'd prefer to push all via Al's tree since there is a VFS change. > > SGTM. Thanks! > > Joel > I've got a doubt and I ask to ocfs2 expert :) It seems i_size_write() and truncate_inode_pages() and so on, they are already called in each path of setattr for a size change, so maybe we can remove truncate_setsize() and simply to remove the vmtuncate code, can you give me your opinion? Thanks. Marco -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/