Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933156Ab2JWPrn (ORCPT ); Tue, 23 Oct 2012 11:47:43 -0400 Received: from mail-we0-f174.google.com ([74.125.82.174]:38688 "EHLO mail-we0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757058Ab2JWPrm (ORCPT ); Tue, 23 Oct 2012 11:47:42 -0400 MIME-Version: 1.0 In-Reply-To: <20121023154226.GB16140@aftab.osrc.amd.com> References: <1350921364-26366-1-git-send-email-kirjanov@gmail.com> <20121023154226.GB16140@aftab.osrc.amd.com> Date: Tue, 23 Oct 2012 19:47:41 +0400 Message-ID: Subject: Re: [PATCH] check the kzalloc return value From: Denis Kirjanov To: Borislav Petkov Cc: linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1373 Lines: 59 I'll resubmit a new patch. Thanks! On 10/23/12, Borislav Petkov wrote: > On Mon, Oct 22, 2012 at 07:56:04PM +0400, Denis Kirjanov wrote: >> > > Needs a commit message. > >> Signed-off-by: Denis Kirjanov >> --- >> drivers/edac/edac_mc_sysfs.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/edac/edac_mc_sysfs.c b/drivers/edac/edac_mc_sysfs.c >> index ed0bc07..55ce016 100644 >> --- a/drivers/edac/edac_mc_sysfs.c >> +++ b/drivers/edac/edac_mc_sysfs.c >> @@ -1128,7 +1128,8 @@ int __init edac_mc_sysfs_init(void) >> } >> >> mci_pdev = kzalloc(sizeof(*mci_pdev), GFP_KERNEL); >> - >> + if (!mci_pdev) >> + return -ENOMEM; > > This either needs to do > > edac_put_sysfs_subsys(); > > on the error-out path. > >> mci_pdev->bus = edac_subsys; >> mci_pdev->type = &mc_attr_type; >> device_initialize(mci_pdev); > > Thanks. > > -- > Regards/Gruss, > Boris. > > Advanced Micro Devices GmbH > Einsteinring 24, 85609 Dornach > GM: Alberto Bozzo > Reg: Dornach, Landkreis Muenchen > HRB Nr. 43632 WEEE Registernr: 129 19551 > -- Regards, Denis -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/