Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933297Ab2JWQ5y (ORCPT ); Tue, 23 Oct 2012 12:57:54 -0400 Received: from mga02.intel.com ([134.134.136.20]:4610 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933203Ab2JWQ5w convert rfc822-to-8bit (ORCPT ); Tue, 23 Oct 2012 12:57:52 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.80,637,1344236400"; d="scan'208";a="209566489" From: "Luck, Tony" To: Kees Cook , "Tirdea, Irina" CC: Anton Vorontsov , Colin Cross , Chris Ball , "linux-kernel@vger.kernel.org" , "Hunter, Adrian" , "Purdila, Octavian" Subject: RE: [PATCH 02/26] pstore: add flags Thread-Topic: [PATCH 02/26] pstore: add flags Thread-Index: AQHNsSRCgPU4i2VyLE+VKGQKhO7lLpfHkUEA//+K6xA= Date: Tue, 23 Oct 2012 16:57:50 +0000 Message-ID: <3908561D78D1C84285E8C5FCA982C28F19D58DE9@ORSMSX108.amr.corp.intel.com> References: <1351000104-13015-1-git-send-email-irina.tirdea@intel.com> <1351000104-13015-3-git-send-email-irina.tirdea@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.22.254.138] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 767 Lines: 16 > I wonder if the default should be to not show headers, and to add this > flag to the backends that want the pstore-added header. I think the > more common case going forward will to be without headers since > backends should arguably storing metadata themselves. Perhaps just add the headings when pstore breaks a dump into pieces because of a back-end size limitation. I.e. if there is only one piece, then no headings. If there are two or more, include a heading to aid with putting the pieces together later. -Tony -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/