Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933430Ab2JWSqB (ORCPT ); Tue, 23 Oct 2012 14:46:01 -0400 Received: from mail-pa0-f46.google.com ([209.85.220.46]:57925 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932824Ab2JWSp6 (ORCPT ); Tue, 23 Oct 2012 14:45:58 -0400 Date: Tue, 23 Oct 2012 11:45:55 -0700 From: Greg KH To: Adil Mujeeb Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, pavel@ucw.cz Subject: Re: [PATCH 0/9] Staging: winbond: Fixed coding style issues Message-ID: <20121023184555.GA3597@kroah.com> References: <1350059835-5408-1-git-send-email-mujeeb.adil@gmail.com> <20121022203405.GA4395@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1986 Lines: 43 On Tue, Oct 23, 2012 at 03:41:08PM +0530, Adil Mujeeb wrote: > On Tue, Oct 23, 2012 at 2:04 AM, Greg KH wrote: > > On Fri, Oct 12, 2012 at 10:07:06PM +0530, Adil Mujeeb wrote: > >> > >> winbond directory files have lots of coding style issues. The patch set tries to remove *most* (if not all) of the coding style issues. checkpatch.pl script is still complaining (like 80 characters limit) but major part of the serious coding style issues have been rectified. > > > > None of your patches can be applied due to the wrong patch level they > > were generated at. Please redo them, drop the two offending patches, > > and resend the whole series. > > > > thanks, > > > > greg k-h > > Thanks Greg. I will recreate the patches and shall drop the mentioned > ones. But I am still not able find where I am doing wrong in > generating the patches. I am following your tutorial :) but may be > missing something. Please help. I am doing in the following ways: > > 1. I am downloading the latest rc source archive from ftp.kernel.org > under directory /pub/linux/kernel/v3.x/testing > 2. Then creating my own git repository treating the base source as master. Why not just use the kernel git tree? You will have to work off of linux-next if you want to send staging patches, you can not keep up with development otherwise. > 3. Creating a branch from it and tries to fix some sources. > 4. Create the patch through git format-patch > 5. Submit the patch through git send-email command. > > Dry run works fine with my repository. Could you please help? Your patches could not be applied with "patch -p1" from the root of the kernel source tree, I think you created your git repo one directory too deep. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/