Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757357Ab2JWSrv (ORCPT ); Tue, 23 Oct 2012 14:47:51 -0400 Received: from mail-bk0-f46.google.com ([209.85.214.46]:40382 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756708Ab2JWSrt (ORCPT ); Tue, 23 Oct 2012 14:47:49 -0400 MIME-Version: 1.0 In-Reply-To: References: <1350593430-24470-1-git-send-email-yinghai@kernel.org> <1350593430-24470-10-git-send-email-yinghai@kernel.org> Date: Tue, 23 Oct 2012 11:47:48 -0700 X-Google-Sender-Auth: WyusQNL6H6J_suNNNPUXu18IjYs Message-ID: Subject: Re: [PATCH 06/19] x86, mm: setup page table in top-down From: Yinghai Lu To: Stefano Stabellini Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Jacob Shin , Tejun Heo , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2299 Lines: 74 On Tue, Oct 23, 2012 at 5:16 AM, Stefano Stabellini wrote: > On Mon, 22 Oct 2012, Yinghai Lu wrote: >> On Mon, Oct 22, 2012 at 11:17 AM, Yinghai Lu wrote: >> > On Mon, Oct 22, 2012 at 6:19 AM, Stefano Stabellini >> >> > How about put sth: >> > --- >> > Xen mmu requires pages from this function should be directly mapped already. >> > --- >> > >> > or you can introduce some doc tag specially that we can out those >> > assumption easily? >> >> I add >> >> /* Xen requires pages from this function should be directly mapped already */ >> >> in [PATCH] x86, mm: Add alloc_low_pages(num) >> >> hope you are happy with that. >> > > It is not bad, but let's just fix the English a bit and give more > context: > > /* Pages returned by this function are already directly mapped. > * > * Changing that is likely to break Xen, see commit > * 279b706bf800b5967037f492dbe4fc5081ad5d0f for more information on the > * subject. > */ I put your change in separate patch. http://git.kernel.org/?p=linux/kernel/git/yinghai/linux-yinghai.git;a=patch;h=bc6e8a77f049f3ecaad291329238367af044aa57 >From bc6e8a77f049f3ecaad291329238367af044aa57 Mon Sep 17 00:00:00 2001 From: Stefano Stabellini Date: Tue, 23 Oct 2012 11:24:07 -0700 Subject: [PATCH] x86, mm: Add pointer about Xen mmu requirement for alloc_low_pages Signed-off-by: Yinghai Lu --- arch/x86/mm/init.c | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/arch/x86/mm/init.c b/arch/x86/mm/init.c index e98a4b8..88f90f7 100644 --- a/arch/x86/mm/init.c +++ b/arch/x86/mm/init.c @@ -25,6 +25,13 @@ unsigned long __meminitdata pgt_buf_top; static unsigned long min_pfn_mapped; +/* + * Pages returned are already directly mapped. + * + * Changing that is likely to break Xen, see commit + * 279b706bf800b5967037f492dbe4fc5081ad5d0f for more information on the + * subject. + */ __ref void *alloc_low_pages(unsigned int num) { unsigned long pfn; -- 1.7.7.6 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/