Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964811Ab2JWXLu (ORCPT ); Tue, 23 Oct 2012 19:11:50 -0400 Received: from mail-we0-f174.google.com ([74.125.82.174]:39094 "EHLO mail-we0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933803Ab2JWXLs (ORCPT ); Tue, 23 Oct 2012 19:11:48 -0400 MIME-Version: 1.0 In-Reply-To: References: <1351022666-6960-1-git-send-email-keescook@chromium.org> <1351022666-6960-159-git-send-email-keescook@chromium.org> Date: Tue, 23 Oct 2012 16:11:47 -0700 X-Google-Sender-Auth: WFn9Z4k4dnnJZUlxdd1WMq4CIzE Message-ID: Subject: Re: [PATCH 158/193] mm: remove CONFIG_EXPERIMENTAL From: Kees Cook To: David Rientjes Cc: linux-kernel@vger.kernel.org, Andrew Morton , KAMEZAWA Hiroyuki , Jan Beulich , Mel Gorman , Seth Jennings Content-Type: text/plain; charset=ISO-8859-1 X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1535 Lines: 46 On Tue, Oct 23, 2012 at 3:46 PM, David Rientjes wrote: > On Tue, 23 Oct 2012, Kees Cook wrote: > >> diff --git a/mm/Kconfig b/mm/Kconfig >> index a3f8ddd..679945e 100644 >> --- a/mm/Kconfig >> +++ b/mm/Kconfig >> @@ -1,6 +1,5 @@ >> config SELECT_MEMORY_MODEL >> def_bool y >> - depends on EXPERIMENTAL || ARCH_SELECT_MEMORY_MODEL >> >> choice >> prompt "Memory model" > > This makes ARCH_SELECT_MEMORY_MODEL pointless, why keep it around? Good point. This seems to trigger much deeper changes. All of these and their logic go away: arch/arm/Kconfig:config ARCH_SELECT_MEMORY_MODEL arch/arm/mach-clps711x/Kconfig: select ARCH_SELECT_MEMORY_MODEL arch/arm64/Kconfig:config ARCH_SELECT_MEMORY_MODEL arch/ia64/Kconfig:config ARCH_SELECT_MEMORY_MODEL arch/parisc/Kconfig:config ARCH_SELECT_MEMORY_MODEL arch/powerpc/Kconfig:config ARCH_SELECT_MEMORY_MODEL arch/s390/Kconfig:config ARCH_SELECT_MEMORY_MODEL arch/sh/mm/Kconfig:config ARCH_SELECT_MEMORY_MODEL arch/sparc/Kconfig:config ARCH_SELECT_MEMORY_MODEL arch/x86/Kconfig:config ARCH_SELECT_MEMORY_MODEL Along with mm/Kconfig:config SELECT_MEMORY_MODEL and associated logic. How about we handle this as a phase 2, and for phase 1, I just drop EXPERIMENTAL? -Kees -- Kees Cook Chrome OS Security -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/