Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934243Ab2JXCfg (ORCPT ); Tue, 23 Oct 2012 22:35:36 -0400 Received: from cn.fujitsu.com ([222.73.24.84]:58056 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S933564Ab2JXCfe convert rfc822-to-8bit (ORCPT ); Tue, 23 Oct 2012 22:35:34 -0400 X-IronPort-AV: E=Sophos;i="4.80,638,1344182400"; d="scan'208";a="6055189" Subject: Re: [RFC PATCH 04/10] sched: Introduce priority-based task migration filter From: li guang To: Morten Rasmussen Cc: Viresh Kumar , "paulmck@linux.vnet.ibm.com" , "pjt@google.com" , "peterz@infradead.org" , "suresh.b.siddha@intel.com" , "linaro-sched-sig@lists.linaro.org" , "linaro-dev@lists.linaro.org" , "linux-kernel@vger.kernel.org" , Amit Kucheria , Arvind Chauhan , Robin Randhawa In-Reply-To: <20121009164045.GB3729@e103034-lin> References: <1348252345-5642-1-git-send-email-morten.rasmussen@arm.com> <1348252345-5642-5-git-send-email-morten.rasmussen@arm.com> <20121009164045.GB3729@e103034-lin> Date: Wed, 24 Oct 2012 10:32:43 +0800 Message-ID: <1351045963.22024.12.camel@liguang.fnst.cn.fujitsu.com> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 X-MIMETrack: Itemize by SMTP Server on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2012/10/24 10:34:49, Serialize by Router on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2012/10/24 10:34:51, Serialize complete at 2012/10/24 10:34:51 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3677 Lines: 99 在 2012-10-09二的 17:40 +0100，Morten Rasmussen写道： > On Thu, Oct 04, 2012 at 07:27:00AM +0100, Viresh Kumar wrote: > > On 22 September 2012 00:02, wrote: > > > > > +config SCHED_HMP_PRIO_FILTER > > > + bool "(EXPERIMENTAL) Filter HMP migrations by task priority" > > > + depends on SCHED_HMP > > > > Should it depend on EXPERIMENTAL? > > > > > + help > > > + Enables task priority based HMP migration filter. Any task with > > > + a NICE value above the threshold will always be on low-power cpus > > > + with less compute capacity. > > > + > > > +config SCHED_HMP_PRIO_FILTER_VAL > > > + int "NICE priority threshold" > > > + default 5 > > > + depends on SCHED_HMP_PRIO_FILTER > > > + > > > config HAVE_ARM_SCU > > > bool > > > help > > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > > > index 490f1f0..8f0f3b9 100644 > > > --- a/kernel/sched/fair.c > > > +++ b/kernel/sched/fair.c > > > @@ -3129,9 +3129,12 @@ static int __init hmp_cpu_mask_setup(void) > > > * hmp_down_threshold: max. load allowed for tasks migrating to a slower cpu > > > * The default values (512, 256) offer good responsiveness, but may need > > > * tweaking suit particular needs. > > > + * > > > + * hmp_up_prio: Only up migrate task with high priority ( > > */ > > > unsigned int hmp_up_threshold = 512; > > > unsigned int hmp_down_threshold = 256; hmp_*_threshold maybe sysctl_hmp_*_threshold, and appear at /proc/sys/kernel, so, can be adjusted to be rational. > > > +unsigned int hmp_up_prio = NICE_TO_PRIO(CONFIG_SCHED_HMP_PRIO_FILTER_VAL); > > > > > > static unsigned int hmp_up_migration(int cpu, struct sched_entity *se); > > > static unsigned int hmp_down_migration(int cpu, struct sched_entity *se); > > > @@ -5491,6 +5494,12 @@ static unsigned int hmp_up_migration(int cpu, struct sched_entity *se) > > > if (hmp_cpu_is_fastest(cpu)) > > > return 0; > > > > > > +#ifdef CONFIG_SCHED_HMP_PRIO_FILTER > > > + /* Filter by task priority */ > > > + if (p->prio >= hmp_up_prio) > > > + return 0; > > > +#endif > > > + > > > if (cpumask_intersects(&hmp_faster_domain(cpu)->cpus, > > > tsk_cpus_allowed(p)) > > > && se->avg.load_avg_ratio > hmp_up_threshold) { > > > @@ -5507,6 +5516,12 @@ static unsigned int hmp_down_migration(int cpu, struct sched_entity *se) > > > if (hmp_cpu_is_slowest(cpu)) > > > return 0; > > > > > > +#ifdef CONFIG_SCHED_HMP_PRIO_FILTER > > > + /* Filter by task priority */ > > > + if (p->prio >= hmp_up_prio) > > > + return 1; > > > +#endif > > > > Even if below cpumask_intersects() fails? > > > > No. Good catch :) > > > > if (cpumask_intersects(&hmp_slower_domain(cpu)->cpus, > > > tsk_cpus_allowed(p)) > > > && se->avg.load_avg_ratio < hmp_down_threshold) { > > > > -- > > viresh > > > > Thanks, > Morten > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- liguang lig.fnst@cn.fujitsu.com FNST linux kernel team -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/