Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934360Ab2JXDir (ORCPT ); Tue, 23 Oct 2012 23:38:47 -0400 Received: from casper.infradead.org ([85.118.1.10]:54428 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934056Ab2JXDiq (ORCPT ); Tue, 23 Oct 2012 23:38:46 -0400 Subject: Re: [PATCH] dmaengine: imx-dma: fix missing unlock on error in imxdma_xfer_desc() From: Vinod Koul To: Wei Yongjun Cc: vinod.koul@intel.com, djbw@fb.com, yongjun_wei@trendmicro.com.cn, linux-kernel@vger.kernel.org In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Date: Wed, 24 Oct 2012 08:54:14 +0530 Message-ID: <1351049054.5263.12.camel@vkoul-udesk3> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1119 Lines: 41 On Sun, 2012-10-21 at 19:58 +0800, Wei Yongjun wrote: > From: Wei Yongjun > > Add the missing unlock on the error handling path in function > imxdma_xfer_desc(). > > Signed-off-by: Wei Yongjun > --- > drivers/dma/imx-dma.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/dma/imx-dma.c b/drivers/dma/imx-dma.c > index f11b5b2..7d9554c 100644 > --- a/drivers/dma/imx-dma.c > +++ b/drivers/dma/imx-dma.c > @@ -474,8 +474,10 @@ static int imxdma_xfer_desc(struct imxdma_desc *d) > slot = i; > break; > } > - if (slot < 0) > + if (slot < 0) { > + spin_unlock_irqrestore(&imxdma->lock, flags); > return -EBUSY; > + } > > imxdma->slots_2d[slot].xsr = d->x; > imxdma->slots_2d[slot].ysr = d->y; > > > -- Thanks applied -- Vinod Koul Intel Corp. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/