Date: Wed, 24 Oct 2012 07:41:14 +0200
From: Thierry Reding <thierry.reding@avionic-design.de>
To: Tony Prisk <linux@prisktech.co.nz>
Cc: arm@kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3] pwm: vt8500: Update vt8500 PWM driver support
Message-ID: <20121024054114.GA9787@avionic-0098.mockup.avionic-design.de>
References: <20121023221419.GA8501@avionic-0098.mockup.avionic-design.de>
 <1351050418-23981-1-git-send-email-linux@prisktech.co.nz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="PEIAKu/WMn1b1Hv9"
Content-Disposition: inline
In-Reply-To: <1351050418-23981-1-git-send-email-linux@prisktech.co.nz>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2254
Lines: 64


--PEIAKu/WMn1b1Hv9
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Oct 24, 2012 at 04:46:58PM +1300, Tony Prisk wrote:
> This patch updates pwm-vt8500.c to support devicetree probing and
> make use of the common clock subsystem.
>=20
> A binding document describing the PWM controller found on
> arch-vt8500 is also included.
>=20
> Signed-off-by: Tony Prisk <linux@prisktech.co.nz>
> ---
> v2/v3:
> Fix errors/coding style as pointed out by Thierry Reding.
>=20
>  .../devicetree/bindings/pwm/vt8500-pwm.txt         |   17 ++++
>  drivers/pwm/pwm-vt8500.c                           |   86 ++++++++++++++=
------
>  2 files changed, 80 insertions(+), 23 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/pwm/vt8500-pwm.txt

Looking real good now. One last comment though and I think I'm ready to
take this...

> +	err =3D clk_enable(vt8500->clk);
> +	if (err < 0)
> +		dev_err(chip->dev, "failed to enable clock\n");
> +		return -EBUSY;
> +	};

Why do you return EBUSY instead of err?

Thierry

--PEIAKu/WMn1b1Hv9
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)

iQIcBAEBAgAGBQJQh396AAoJEN0jrNd/PrOhubEP/iHI7DiFitkKygmOv0Cnx7fp
hVcTfGtznZofSj2yENf6RTUNpNT77LL1QBHr+0M+mPgcbddDJABq6TPrFgtTXJhy
KRTTcsLHPaoBGWUnyWYtUZJh5R2ekt7kPguZJxGyYDrinjyZ9lTrY+bQdLbWh2ZX
8TotGqcWLh5wX/4tvUOHcPweFpeq5pR8x/MDcXdGYqkF13Yr5OutdF6tRJgvWdyL
WK/hTtimKe0LCgnuqHsvUQ6aL3aMFvzOvMZqyvlgGBu8o+Ohg/VivBR0y1314Jl/
V+DB7V8x7kdhVVKFtWchrKrD802ciqPFNhtpeR4MZRhAH7B2u1E0HOVMecoLsWDM
G6H5hRrG8ty+eX9DBnV+cKX3JQkxYIULvs4W+hKMIDWpJ4ep6qfsqHJQgKjt9JIQ
4aAh75Y1jGpEV9ZrIuNPiYBproFPdSmm3hI/+0tIhqAVwcjxbolu9LbRlhgQ98O7
YDkfbTatlLXngCPMwic3zoSiGg1nWEbhGl0Kv4EZRPtfca08mzJETXZq9T+vvyQg
QHtuyCF5OIivNZDJVePGV4d0UAIF8Aogl7JfoJrOJjmjb3X2tdSXQ519b8wuuAC6
mrpVq1en0Esj5jb8BMBXrjCx7/s7ejj/T4/2Ge52GRD58LQLa3fSeQVRDqVs5Ii6
3CTpgmd+n+QQe0pZFx9p
=e66U
-----END PGP SIGNATURE-----

--PEIAKu/WMn1b1Hv9--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/