Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933700Ab2JXMsI (ORCPT ); Wed, 24 Oct 2012 08:48:08 -0400 Received: from mail-ia0-f174.google.com ([209.85.210.174]:48681 "EHLO mail-ia0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932517Ab2JXMsG (ORCPT ); Wed, 24 Oct 2012 08:48:06 -0400 MIME-Version: 1.0 Reply-To: mtk.manpages@gmail.com In-Reply-To: References: <87txu17lss.fsf@rustcorp.com.au> From: "Michael Kerrisk (man-pages)" Date: Wed, 24 Oct 2012 14:47:43 +0200 Message-ID: Subject: Re: [Request for review] Revised delete_module(2) manual page To: Lucas De Marchi Cc: Rusty Russell , Kees Cook , linux-kernel@vger.kernel.org, linux-man , Lucas De Marchi , Jon Masters Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1448 Lines: 50 Lucas, On Wed, Oct 24, 2012 at 7:27 AM, Lucas De Marchi wrote: > Hi Michael, > > > On Sun, Oct 21, 2012 at 5:36 AM, Michael Kerrisk (man-pages) > wrote: >> Ping! >> >> Rusty (et al.) I'm pretty sure the new page text is okay, but I would >> like someone knowledgeable to confirm. > > One more thing: > >> .SH "SEE ALSO" >> .BR create_module (2), >> .BR init_module (2), >> .BR query_module (2), >> .BR lsmod (8), >> .BR rmmod (8) > > Shouldn't we remove the reference to query_module(2) and > create_module(2)? They don't exist anymore (and I miss a bigger > warning on their man pages). I think the SEE ALSO links should be kept, but you are right that the warnings that query_module(2) and create_module(2) no longer exist should be more prominent on those pages. By chance, I'd already made that change. > Last, I think there should be a ref here to modprobe (because of -r > flag), not lsmod. The rest looks good. I'll add modprobe(8); I think lsmod(8) is worth keeping. Cheers, Michael -- Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Author of "The Linux Programming Interface"; http://man7.org/tlpi/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/