Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934871Ab2JXN4r (ORCPT ); Wed, 24 Oct 2012 09:56:47 -0400 Received: from mail.free-electrons.com ([88.190.12.23]:49135 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934751Ab2JXN4p (ORCPT ); Wed, 24 Oct 2012 09:56:45 -0400 Message-ID: <5087F38B.1010508@free-electrons.com> Date: Wed, 24 Oct 2012 15:56:27 +0200 From: Gregory CLEMENT User-Agent: Mozilla/5.0 (X11; Linux i686; rv:15.0) Gecko/20120912 Thunderbird/15.0.1 MIME-Version: 1.0 To: Arnd Bergmann CC: Lior Amsalem , Andrew Lunn , Ike Pan , Nadav Haklai , Ian Molton , David Marlin , Yehuda Yitschak , Jani Monoses , Russell King , Tawfik Bayouk , Dan Frazier , Eran Ben-Avi , Leif Lindholm , Sebastian Hesselbarth , Jason Cooper , Jon Masters , Rob Herring , Ben Dooks , linux-arm-kernel@lists.infradead.org, Thomas Petazzoni , Chris Van Hoof , Nicolas Pitre , linux-kernel@vger.kernel.org, Maen Suleiman , Shadi Ammouri , Olof Johansson Subject: Re: [PATCH 2/2] arm: mvebu: Add hardware I/O Coherency support References: <1351065841-18654-1-git-send-email-gregory.clement@free-electrons.com> <5087D574.4030503@free-electrons.com> <5087D6B8.10209@free-electrons.com> <201210241224.06791.arnd@arndb.de> In-Reply-To: <201210241224.06791.arnd@arndb.de> X-Enigmail-Version: 1.4.4 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2357 Lines: 55 On 10/24/2012 02:24 PM, Arnd Bergmann wrote: > On Wednesday 24 October 2012, Gregory CLEMENT wrote: >> On 10/24/2012 01:48 PM, Gregory CLEMENT wrote: >>> On 10/24/2012 01:36 PM, Arnd Bergmann wrote: >>>> >>>> I think it would be cleaner to statically define the operations in a constant >>>> structure and point directly to the functions you need. If necessary, use >>>> multiple structures. >>> >>> My problem was that these functions are not exposed, only arm_dma_op and >>> arm_coherent_dma_ops are exported. >>> Or do you think about something like this: >> >> struct dma_map_ops *dma_ops = { >> .alloc = arm_coherent_dma_ops.arm_coherent_dma_alloc, >> .free = arm_coherent_dma_ops.arm_coherent_dma_free, >> .mmap = arm_coherent_dma_ops.arm_dma_mmap, >> .get_sgtable = arm_coherent_dma_ops.arm_dma_get_sgtable, >> .map_sg = arm_coherent_dma_ops.arm_dma_map_sg, >> .set_dma_mask = arm_coherent_dma_ops.arm_dma_set_mask, >> .map_page = armada_xp_dma_map_page, >> .unmap_page = armada_xp_dma_unmap_page, >> .unmap_sg = arm_dma_ops.unmap_sg, >> .sync_single_for_cpu = armada_xp_dma_sync, >> .sync_single_for_device = armada_xp_dma_sync, >> .sync_sg_for_cpu = arm_dma_ops.sync_sg_for_cpu, >> .sync_sg_for_device = arm_dma_ops.sync_sg_for_device, >> }; > > No, I was thinking of making the underlying functions globally visible > and have extern declarations in a header file so you can access them > directly. > > Generally speaking, when you run into a problem with common code, your > first approach should be to fix the common code before you try to work > around it. OK I thought it was done on purpose. But if you consider it needs to be fixed I will add patch for it in next version. > > Arnd > -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/