Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934894Ab2JXOGE (ORCPT ); Wed, 24 Oct 2012 10:06:04 -0400 Received: from mail.free-electrons.com ([88.190.12.23]:49282 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934814Ab2JXOGC (ORCPT ); Wed, 24 Oct 2012 10:06:02 -0400 Message-ID: <5087F5B9.0@free-electrons.com> Date: Wed, 24 Oct 2012 16:05:45 +0200 From: Gregory CLEMENT User-Agent: Mozilla/5.0 (X11; Linux i686; rv:15.0) Gecko/20120912 Thunderbird/15.0.1 MIME-Version: 1.0 To: Thomas Petazzoni CC: Jason Cooper , Andrew Lunn , linux-arm-kernel@lists.infradead.org, Arnd Bergmann , Olof Johansson , Ben Dooks , Ian Molton , Nicolas Pitre , Lior Amsalem , Maen Suleiman , Tawfik Bayouk , Shadi Ammouri , Eran Ben-Avi , Yehuda Yitschak , Nadav Haklai , Ike Pan , Jani Monoses , Chris Van Hoof , Dan Frazier , Leif Lindholm , Jon Masters , David Marlin , Sebastian Hesselbarth , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] arm: mvebu: adding SATA support: dt binding and config update References: <1351086561-13569-1-git-send-email-gregory.clement@free-electrons.com> <1351086561-13569-3-git-send-email-gregory.clement@free-electrons.com> <20121024160139.6dbf5e16@skate> In-Reply-To: <20121024160139.6dbf5e16@skate> X-Enigmail-Version: 1.4.4 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1575 Lines: 45 On 10/24/2012 04:01 PM, Thomas Petazzoni wrote: > Hello, > > Shouldn't you split into one commit adding the SATA definition in > the .dtsi + doing the defconfig change (the "SoC" level modifications), > and then another commit for the .dts change? I don't really care > personally, it's really up to Jason/Andrew on this. > > Another comment below, though. > > On Wed, 24 Oct 2012 15:49:21 +0200, Gregory CLEMENT wrote: > >> diff --git a/arch/arm/boot/dts/armada-370-xp.dtsi b/arch/arm/boot/dts/armada-370-xp.dtsi >> index 94b4b9e..3f08233 100644 >> --- a/arch/arm/boot/dts/armada-370-xp.dtsi >> +++ b/arch/arm/boot/dts/armada-370-xp.dtsi >> @@ -69,6 +69,16 @@ >> compatible = "marvell,armada-addr-decoding-controller"; >> reg = <0xd0020000 0x258>; >> }; >> + >> + sata@d00a0000 { >> + compatible = "marvell,orion-sata"; >> + reg = <0xd00a0000 0x2400>; >> + interrupts = <55>; >> + nr-ports = <2>; >> + clocks = <&coreclk 0>;//, <&coreclk 0>; > > Alignment problem + remainings of tests or something like that. True I missed this one. Jason, Andrew, do you want I split this patch as suggested by Thomas or are you fine with having one single patch? I will wait your answer before sending the V2. Thanks, Gregory -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/