Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934898Ab2JXOIp (ORCPT ); Wed, 24 Oct 2012 10:08:45 -0400 Received: from londo.lunn.ch ([80.238.139.98]:49456 "EHLO londo.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934843Ab2JXOIn (ORCPT ); Wed, 24 Oct 2012 10:08:43 -0400 Date: Wed, 24 Oct 2012 16:08:01 +0200 From: Andrew Lunn To: Gregory CLEMENT Cc: Jason Cooper , Andrew Lunn , linux-arm-kernel@lists.infradead.org, Arnd Bergmann , Olof Johansson , Ben Dooks , Ian Molton , Nicolas Pitre , Lior Amsalem , Maen Suleiman , Tawfik Bayouk , Shadi Ammouri , Eran Ben-Avi , Yehuda Yitschak , Nadav Haklai , Ike Pan , Jani Monoses , Chris Van Hoof , Dan Frazier , Thomas Petazzoni , Leif Lindholm , Jon Masters , David Marlin , Sebastian Hesselbarth , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] arm: mvebu: adding SATA support: dt binding and config update Message-ID: <20121024140801.GB11837@lunn.ch> References: <1351086561-13569-1-git-send-email-gregory.clement@free-electrons.com> <1351086561-13569-3-git-send-email-gregory.clement@free-electrons.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1351086561-13569-3-git-send-email-gregory.clement@free-electrons.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2477 Lines: 76 On Wed, Oct 24, 2012 at 03:49:21PM +0200, Gregory CLEMENT wrote: > From: Lior Amsalem > > Signed-off-by: Gregory CLEMENT > Signed-off-by: Lior Amsalem > --- > arch/arm/boot/dts/armada-370-db.dts | 3 +++ > arch/arm/boot/dts/armada-370-xp.dtsi | 10 ++++++++++ > arch/arm/boot/dts/armada-xp-db.dts | 3 +++ > arch/arm/configs/mvebu_defconfig | 7 +++++++ > 4 files changed, 23 insertions(+) > > diff --git a/arch/arm/boot/dts/armada-370-db.dts b/arch/arm/boot/dts/armada-370-db.dts > index 4a31b03..2a2aa75 100644 > --- a/arch/arm/boot/dts/armada-370-db.dts > +++ b/arch/arm/boot/dts/armada-370-db.dts > @@ -34,5 +34,8 @@ > clock-frequency = <200000000>; > status = "okay"; > }; > + sata@d00a0000 { > + status = "okay"; > + }; > }; > }; > diff --git a/arch/arm/boot/dts/armada-370-xp.dtsi b/arch/arm/boot/dts/armada-370-xp.dtsi > index 94b4b9e..3f08233 100644 > --- a/arch/arm/boot/dts/armada-370-xp.dtsi > +++ b/arch/arm/boot/dts/armada-370-xp.dtsi > @@ -69,6 +69,16 @@ > compatible = "marvell,armada-addr-decoding-controller"; > reg = <0xd0020000 0x258>; > }; > + > + sata@d00a0000 { > + compatible = "marvell,orion-sata"; > + reg = <0xd00a0000 0x2400>; > + interrupts = <55>; > + nr-ports = <2>; > + clocks = <&coreclk 0>;//, <&coreclk 0>; > + status = "disabled"; > + }; > + > }; > }; > > diff --git a/arch/arm/boot/dts/armada-xp-db.dts b/arch/arm/boot/dts/armada-xp-db.dts > index b1fc728..b0db9a3 100644 > --- a/arch/arm/boot/dts/armada-xp-db.dts > +++ b/arch/arm/boot/dts/armada-xp-db.dts > @@ -46,5 +46,8 @@ > clock-frequency = <250000000>; > status = "okay"; > }; > + sata@d00a0000 { > + status = "okay"; > + }; > }; > }; Hi Gregory Should there be some pinctrl setup somewhere, to ensure the pins used for SATA are really setup up for SATA? Also, for kirkwood, the number of SATA ports varies. So we don't define it in the base kirkwood.dtsi and leave each board to set it. Do we want to be consistent between kirkwood and 370/xp? Thanks Andrew -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/