Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965225Ab2JXPVt (ORCPT ); Wed, 24 Oct 2012 11:21:49 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:36760 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965198Ab2JXPVq (ORCPT ); Wed, 24 Oct 2012 11:21:46 -0400 Message-ID: <50880774.5090605@ti.com> Date: Wed, 24 Oct 2012 20:51:24 +0530 From: Santosh Shilimkar User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120912 Thunderbird/15.0.1 MIME-Version: 1.0 To: Vincent Guittot CC: , , , , , , Subject: Re: [RFC 5/6] sched: pack the idle load balance References: <1349595838-31274-1-git-send-email-vincent.guittot@linaro.org> <1349595838-31274-6-git-send-email-vincent.guittot@linaro.org> In-Reply-To: <1349595838-31274-6-git-send-email-vincent.guittot@linaro.org> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1581 Lines: 52 On Sunday 07 October 2012 01:13 PM, Vincent Guittot wrote: > Look for an idle CPU close the pack buddy CPU whenever possible. s/close/close to > The goal is to prevent the wake up of a CPU which doesn't share the power > line of the pack CPU > > Signed-off-by: Vincent Guittot > --- > kernel/sched/fair.c | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index 6df53b5..f76acdc 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -5158,7 +5158,25 @@ static struct { > > static inline int find_new_ilb(int call_cpu) > { > + struct sched_domain *sd; > int ilb = cpumask_first(nohz.idle_cpus_mask); > + int buddy = per_cpu(sd_pack_buddy, call_cpu); > + > + /* > + * If we have a pack buddy CPU, we try to run load balance on a CPU > + * that is close to the buddy. > + */ > + if (buddy != -1) > + for_each_domain(buddy, sd) { > + if (sd->flags & SD_SHARE_CPUPOWER) > + continue; Do you mean SD_SHARE_POWERLINE here ? > + > + ilb = cpumask_first_and(sched_domain_span(sd), > + nohz.idle_cpus_mask); > + > + if (ilb < nr_cpu_ids) > + break; > + } > > if (ilb < nr_cpu_ids && idle_cpu(ilb)) > return ilb; > Can you please expand "idle CPU _close_ the pack buddy CPU" ? Regards santosh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/