Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935229Ab2JXQe1 (ORCPT ); Wed, 24 Oct 2012 12:34:27 -0400 Received: from acsinet15.oracle.com ([141.146.126.227]:42879 "EHLO acsinet15.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935210Ab2JXQeY (ORCPT ); Wed, 24 Oct 2012 12:34:24 -0400 To: Vivek Goyal Cc: Tejun Heo , Kent Overstreet , linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org, dm-devel@redhat.com, axboe@kernel.dk, martin.petersen@oracle.com Subject: Re: [PATCH v4 1/2] block: Fix a buffer overrun in bio_integrity_split() From: "Martin K. Petersen" Organization: Oracle References: <1350331769-14856-1-git-send-email-koverstreet@google.com> <1350331769-14856-28-git-send-email-koverstreet@google.com> <20121019203015.GS13370@google.com> <20121022153907.GC3401@redhat.com> Date: Wed, 24 Oct 2012 12:34:14 -0400 In-Reply-To: <20121022153907.GC3401@redhat.com> (Vivek Goyal's message of "Mon, 22 Oct 2012 11:39:07 -0400") Message-ID: User-Agent: Gnus/5.130005 (Ma Gnus v0.5) Emacs/24.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: acsinet22.oracle.com [141.146.126.238] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 699 Lines: 19 >>>>> "Vivek" == Vivek Goyal writes: Vivek> Initially he had reordered the bio_pair fields but there were Vivek> couple of issues. We could not assume that there is no padding Vivek> between fields and secondly some of the initializtion of looked Vivek> plain ugly. Vivek> IMHO, introduction of bip_vec to fix this issue is small and Vivek> cleaner then reordering fields. I agree. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/