Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757075Ab2JXQmu (ORCPT ); Wed, 24 Oct 2012 12:42:50 -0400 Received: from mail-lb0-f174.google.com ([209.85.217.174]:57806 "EHLO mail-lb0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753555Ab2JXQms (ORCPT ); Wed, 24 Oct 2012 12:42:48 -0400 MIME-Version: 1.0 In-Reply-To: References: <1350331769-14856-1-git-send-email-koverstreet@google.com> <1350331769-14856-28-git-send-email-koverstreet@google.com> <20121019203015.GS13370@google.com> <20121022153907.GC3401@redhat.com> Date: Wed, 24 Oct 2012 12:42:46 -0400 X-Google-Sender-Auth: EQ2uobe9IPoB7rSKEi_o_xMMR5w Message-ID: Subject: Re: [PATCH v4 1/2] block: Fix a buffer overrun in bio_integrity_split() From: Tejun Heo To: "Martin K. Petersen" Cc: Vivek Goyal , Kent Overstreet , linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org, dm-devel@redhat.com, axboe@kernel.dk Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1151 Lines: 32 Hey, guys. On Wed, Oct 24, 2012 at 12:34 PM, Martin K. Petersen wrote: >>>>>> "Vivek" == Vivek Goyal writes: > > Vivek> Initially he had reordered the bio_pair fields but there were > Vivek> couple of issues. We could not assume that there is no padding > Vivek> between fields and secondly some of the initializtion of looked > Vivek> plain ugly. > > Vivek> IMHO, introduction of bip_vec to fix this issue is small and > Vivek> cleaner then reordering fields. > > I agree. If Martin is happy with it, I'm not gonna push it but putting the respective storage member after one containing vararray at the end is a legit way to allocate the area statically. As long as the storage field is marked as such and not accessed directly, it doesn't matter whether there's padding inbetween or not. Anyways, let's push this one to -stable then. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/