Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757615Ab2JXRFa (ORCPT ); Wed, 24 Oct 2012 13:05:30 -0400 Received: from mail-vc0-f174.google.com ([209.85.220.174]:52940 "EHLO mail-vc0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753730Ab2JXRF1 (ORCPT ); Wed, 24 Oct 2012 13:05:27 -0400 MIME-Version: 1.0 In-Reply-To: <20121024134831.GB7217@sergelap> References: <1351022666-6960-1-git-send-email-keescook@chromium.org> <1351022666-6960-156-git-send-email-keescook@chromium.org> <20121024134831.GB7217@sergelap> Date: Wed, 24 Oct 2012 10:05:25 -0700 X-Google-Sender-Auth: k_OOEo6ANw6wCDnUOdFwRlTvpbQ Message-ID: Subject: Re: [PATCH 155/193] init: remove CONFIG_EXPERIMENTAL From: Kees Cook To: Serge Hallyn Cc: linux-kernel@vger.kernel.org, "Eric W. Biederman" , "Paul E. McKenney" , Andrew Morton , Frederic Weisbecker Content-Type: text/plain; charset=ISO-8859-1 X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2651 Lines: 65 On Wed, Oct 24, 2012 at 6:48 AM, Serge Hallyn wrote: > Quoting Kees Cook (keescook@chromium.org): >> This config item has not carried much meaning for a while now and is >> almost always enabled by default. As agreed during the Linux kernel >> summit, remove it. >> >> CC: "Eric W. Biederman" >> CC: Serge Hallyn >> CC: "Paul E. McKenney" >> CC: Andrew Morton >> CC: Frederic Weisbecker >> Signed-off-by: Kees Cook >> --- >> init/Kconfig | 23 ++++++++++------------- >> 1 file changed, 10 insertions(+), 13 deletions(-) >> >> diff --git a/init/Kconfig b/init/Kconfig >> index 2bf7b83..4b65c1c 100644 >> --- a/init/Kconfig >> +++ b/init/Kconfig >> @@ -220,7 +220,7 @@ config SYSVIPC_SYSCTL >> >> config POSIX_MQUEUE >> bool "POSIX Message Queues" >> - depends on NET && EXPERIMENTAL >> + depends on NET >> ---help--- >> POSIX variant of message queues is a part of IPC. In POSIX message >> queues every message has a priority which decides about succession >> @@ -366,7 +366,7 @@ config BSD_PROCESS_ACCT_V3 >> at . >> >> config TASKSTATS >> - bool "Export task/process statistics through netlink (EXPERIMENTAL)" >> + bool "Export task/process statistics through netlink" > > In these cases, should we keep the '(EXPERIMENTAL)' text since it is just > a hint to anyone running make menuconfig? I think removing the 'depends on > EXPERIMENTAL's is fine, but cases we should leave it (or replace it) as > a textual hint, except in cases where we're sure that is no longer the case. I covered this in the 000 intro email (https://lkml.org/lkml/2012/10/23/580): Some patches remove "(EXPERIMENTAL)" from Kconfig titles when there was no "depends on EXPERIMENTAL". I've removed the cases of these where I know the maintainer intended it that way. I've left the others in case a "depends on EXPERIMENTAL" had been removed in the past and it had been accidentally forgotten in the title. If the title is correct as-is, just let me know, and I'll drop the patch from my series. So, if some of these need to be adjusted, I'm fine with that. I opted for aggressive removal in this first series. -Kees -- Kees Cook Chrome OS Security -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/