Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965158Ab2JXUOL (ORCPT ); Wed, 24 Oct 2012 16:14:11 -0400 Received: from woodbine.london.02.net ([87.194.255.145]:41540 "EHLO woodbine.london.02.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757988Ab2JXUOK convert rfc822-to-8bit (ORCPT ); Wed, 24 Oct 2012 16:14:10 -0400 From: Matthew Leach To: Richard Weinberger Cc: linux-kernel@vger.kernel.org, Martin =?utf-8?Q?P=C3=A4rtel?= Subject: Re: [REGRESSION] uml: signal.c build errors References: <87pq48lqut.fsf@mattleach.net> <20121024213919.5543e90b@spider.haslach.nod.at> <87objr3b2z.fsf@mattleach.net> <20121024215445.04d53d0d@spider.haslach.nod.at> <87hapj3a9q.fsf@mattleach.net> <20121024220917.239390bf@spider.haslach.nod.at> Date: Wed, 24 Oct 2012 21:13:55 +0100 In-Reply-To: <20121024220917.239390bf@spider.haslach.nod.at> (Richard Weinberger's message of "Wed, 24 Oct 2012 22:09:17 +0200") Message-ID: <87d30739x8.fsf@mattleach.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2798 Lines: 70 Richard Weinberger writes: > Am Wed, 24 Oct 2012 21:06:25 +0100 > schrieb Matthew Leach : > >> Richard Weinberger writes: >> > Am Wed, 24 Oct 2012 20:48:52 +0100 >> > schrieb Matthew Leach : >> > >> >> >> >> Richard Weinberger writes: >> >> > Am Wed, 24 Oct 2012 00:18:34 +0100 >> >> >> I have tracked this down to [1] where, indeed, the type of >> >> >> sig_info is different; the second parameter in signal.c is >> >> >> 'siginfo_t' where as in as-layout.h the second parameter's type >> >> >> is declared as 'struct siginfo'. >> >> >> >> >> >> [1]: d3c1cfcdb43e023ab1b1c7a555cd9e929026500a >> >> > >> >> > Looks like we have to revert that commit. >> >> > Moving everything to siginfo_t requires a non-trivial header >> >> > cleanup and may introduce new regressions. >> >> > >> >> > Matthew, does the attached revert patch help? >> >> >> >> The revert did remove the errors for the compilation of signal.c, >> >> so that seems fine. I still get the following errors, however: >> >> >> >> CC arch/um/os-Linux/sigio.o >> >> CC arch/um/os-Linux/signal.o >> >> CC arch/um/os-Linux/start_up.o >> >> arch/um/os-Linux/start_up.c: In function ‘check_coredump_limit’: >> >> arch/um/os-Linux/start_up.c:338:16: error: storage size of ‘lim’ >> >> isn’t known arch/um/os-Linux/start_up.c:339:2: error: implicit >> >> declaration of function >> >> ‘getrlimit’ [-Werror=implicit-function-declaration] >> >> arch/um/os-Linux/start_up.c:339:22: error: ‘RLIMIT_CORE’ undeclared >> >> (first use in this function) arch/um/os-Linux/start_up.c:339:22: >> >> note: each undeclared identifier is reported only once for each >> >> function it appears in arch/um/os-Linux/start_up.c:347:22: error: >> >> ‘RLIM_INFINITY’ undeclared (first use in this function) >> >> arch/um/os-Linux/start_up.c:338:16: warning: unused variable >> >> ‘lim’ [-Wunused-variable] cc1: some warnings being treated as >> >> errors make[1]: *** [arch/um/os-Linux/start_up.o] Error 1 make: *** >> >> [arch/um/os-Linux] Error 2 >> > >> > Does adding >> > #include >> > #include >> > >> > to arch/um/os-Linux/start_up.c help? >> >> Adding the above includes and the revert commit did the trick! > > Thanks a lot for being my build bot. ;) Not a problem :). > I'm not able to reproduce the issue on any of my machines. Strange - well I'm using a fully up-to-date Arch Linux x86_64 distro, if that helps. Thanks, Matt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/