Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161382Ab2JXV4P (ORCPT ); Wed, 24 Oct 2012 17:56:15 -0400 Received: from ogre.sisk.pl ([193.178.161.156]:35607 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161313Ab2JXV4I (ORCPT ); Wed, 24 Oct 2012 17:56:08 -0400 From: "Rafael J. Wysocki" To: Viresh Kumar Cc: Joe Perches , cpufreq@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linaro-dev@lists.linaro.org, patches@linaro.org, pdsw-power-team@arm.com Subject: Re: [PATCH 1/2] cpufreq: Improve debug prints Date: Thu, 25 Oct 2012 00:00:03 +0200 Message-ID: <1952796.OHncReY41t@vostro.rjw.lan> User-Agent: KMail/4.8.5 (Linux/3.6.2-6-desktop; KDE/4.8.5; x86_64; ; ) In-Reply-To: References: <3b38cb8ab136e5af3a70fceb7d77ad9fc889eb3f.1350451100.git.viresh.kumar@linaro.org> <1350455212.3072.27.camel@joe-AO722> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3270 Lines: 111 On Wednesday 17 of October 2012 12:03:31 Viresh Kumar wrote: > On 17 October 2012 11:56, Joe Perches wrote: > > Oh good, but please use a space between KBUILD_MODNAME > > and the quoted ": ". > > Anything technical behind it or just for code formatting? As output is > same in both cases :) > > ------------------------8<----------------------8<------------------- > > From: Viresh Kumar > Date: Wed, 17 Oct 2012 10:38:31 +0530 > Subject: [PATCH] cpufreq: Improve debug prints > > With debug options on, it is difficult to locate cpufreq core's debug prints. > Fix this by prefixing debug prints with KBUILD_MODNAME. > > Signed-off-by: Viresh Kumar Applied to linux-pm.git/linux-next as v3.8 material. Thanks, Rafael > --- > drivers/cpufreq/cpufreq.c | 2 ++ > drivers/cpufreq/cpufreq_performance.c | 2 ++ > drivers/cpufreq/cpufreq_powersave.c | 2 ++ > drivers/cpufreq/cpufreq_userspace.c | 2 ++ > drivers/cpufreq/freq_table.c | 2 ++ > 5 files changed, 10 insertions(+) > > diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c > index db6e337..85df538 100644 > --- a/drivers/cpufreq/cpufreq.c > +++ b/drivers/cpufreq/cpufreq.c > @@ -15,6 +15,8 @@ > * > */ > > +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > + > #include > #include > #include > diff --git a/drivers/cpufreq/cpufreq_performance.c > b/drivers/cpufreq/cpufreq_performance.c > index f13a8a9..ceee068 100644 > --- a/drivers/cpufreq/cpufreq_performance.c > +++ b/drivers/cpufreq/cpufreq_performance.c > @@ -10,6 +10,8 @@ > * > */ > > +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > + > #include > #include > #include > diff --git a/drivers/cpufreq/cpufreq_powersave.c > b/drivers/cpufreq/cpufreq_powersave.c > index 4c2eb51..2d948a1 100644 > --- a/drivers/cpufreq/cpufreq_powersave.c > +++ b/drivers/cpufreq/cpufreq_powersave.c > @@ -10,6 +10,8 @@ > * > */ > > +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > + > #include > #include > #include > diff --git a/drivers/cpufreq/cpufreq_userspace.c > b/drivers/cpufreq/cpufreq_userspace.c > index bedac1a..c8c3d29 100644 > --- a/drivers/cpufreq/cpufreq_userspace.c > +++ b/drivers/cpufreq/cpufreq_userspace.c > @@ -11,6 +11,8 @@ > * > */ > > +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > + > #include > #include > #include > diff --git a/drivers/cpufreq/freq_table.c b/drivers/cpufreq/freq_table.c > index 90431cb..49cda25 100644 > --- a/drivers/cpufreq/freq_table.c > +++ b/drivers/cpufreq/freq_table.c > @@ -9,6 +9,8 @@ > * > */ > > +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > + > #include > #include > #include > -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/