Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422823Ab2JXWsV (ORCPT ); Wed, 24 Oct 2012 18:48:21 -0400 Received: from mail.skyhub.de ([78.46.96.112]:47620 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1422669Ab2JXWsU (ORCPT ); Wed, 24 Oct 2012 18:48:20 -0400 Date: Thu, 25 Oct 2012 00:48:17 +0200 From: Borislav Petkov To: Dave Hansen Cc: Andrew Morton , Michal Hocko , linux-mm@kvack.org, KAMEZAWA Hiroyuki , KOSAKI Motohiro , LKML Subject: Re: [PATCH] add some drop_caches documentation and info messsge Message-ID: <20121024224817.GB8828@liondog.tnic> Mail-Followup-To: Borislav Petkov , Dave Hansen , Andrew Morton , Michal Hocko , linux-mm@kvack.org, KAMEZAWA Hiroyuki , KOSAKI Motohiro , LKML References: <20121012125708.GJ10110@dhcp22.suse.cz> <20121023164546.747e90f6.akpm@linux-foundation.org> <20121024062938.GA6119@dhcp22.suse.cz> <20121024125439.c17a510e.akpm@linux-foundation.org> <50884F63.8030606@linux.vnet.ibm.com> <20121024134836.a28d223a.akpm@linux-foundation.org> <20121024210600.GA17037@liondog.tnic> <50885B2E.5050500@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <50885B2E.5050500@linux.vnet.ibm.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 837 Lines: 22 On Wed, Oct 24, 2012 at 02:18:38PM -0700, Dave Hansen wrote: > Sounds fairly valid to me. But, it's also one that would not be harmed > or disrupted in any way because of a single additional printk() during > each suspend-to-disk operation. Btw, back to the drop_caches patch. How about we hide the drop_caches interface behind some mm debugging option in "Kernel Hacking"? Assuming we don't need it otherwise on production kernels. Probably make it depend on CONFIG_DEBUG_VM like CONFIG_DEBUG_VM_RB or so. And then also add it to /proc/vmstat, in addition. -- Regards/Gruss, Boris. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/