Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422839Ab2JXW5o (ORCPT ); Wed, 24 Oct 2012 18:57:44 -0400 Received: from e38.co.us.ibm.com ([32.97.110.159]:53329 "EHLO e38.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1422652Ab2JXW5n (ORCPT ); Wed, 24 Oct 2012 18:57:43 -0400 Message-ID: <5088725B.2090700@linux.vnet.ibm.com> Date: Wed, 24 Oct 2012 15:57:31 -0700 From: Dave Hansen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120912 Thunderbird/15.0.1 MIME-Version: 1.0 To: Borislav Petkov , Andrew Morton , Michal Hocko , linux-mm@kvack.org, KAMEZAWA Hiroyuki , KOSAKI Motohiro , LKML Subject: Re: [PATCH] add some drop_caches documentation and info messsge References: <20121012125708.GJ10110@dhcp22.suse.cz> <20121023164546.747e90f6.akpm@linux-foundation.org> <20121024062938.GA6119@dhcp22.suse.cz> <20121024125439.c17a510e.akpm@linux-foundation.org> <50884F63.8030606@linux.vnet.ibm.com> <20121024134836.a28d223a.akpm@linux-foundation.org> <20121024210600.GA17037@liondog.tnic> <50885B2E.5050500@linux.vnet.ibm.com> <20121024224817.GB8828@liondog.tnic> In-Reply-To: <20121024224817.GB8828@liondog.tnic> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Content-Scanned: Fidelis XPS MAILER x-cbid: 12102422-5518-0000-0000-000008B3ED67 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1085 Lines: 23 On 10/24/2012 03:48 PM, Borislav Petkov wrote: > On Wed, Oct 24, 2012 at 02:18:38PM -0700, Dave Hansen wrote: >> Sounds fairly valid to me. But, it's also one that would not be harmed >> or disrupted in any way because of a single additional printk() during >> each suspend-to-disk operation. > > back to the drop_caches patch. How about we hide the drop_caches > interface behind some mm debugging option in "Kernel Hacking"? Assuming > we don't need it otherwise on production kernels. Probably make it > depend on CONFIG_DEBUG_VM like CONFIG_DEBUG_VM_RB or so. > > And then also add it to /proc/vmstat, in addition. That effectively means removing it from the kernel since distros ship with those config options off. We don't want to do that since there _are_ valid, occasional uses like benchmarking that we want to be consistent. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/