Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758906Ab2JXXoW (ORCPT ); Wed, 24 Oct 2012 19:44:22 -0400 Received: from acsinet15.oracle.com ([141.146.126.227]:47800 "EHLO acsinet15.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750934Ab2JXXoV (ORCPT ); Wed, 24 Oct 2012 19:44:21 -0400 Date: Wed, 24 Oct 2012 16:44:11 -0700 From: Mukesh Rathor To: Ian Campbell Cc: Konrad Rzeszutek Wilk , Stefano Stabellini , linux-kernel , xen-devel Subject: Re: [Xen-devel] [PATCH 4/5] xen: arm: implement remap interfaces needed for privcmd mappings. Message-ID: <20121024164411.5b000087@mantra.us.oracle.com> In-Reply-To: <1351084777-28898-4-git-send-email-ian.campbell@citrix.com> References: <1351084756.18035.28.camel@zakaz.uk.xensource.com> <1351084777-28898-4-git-send-email-ian.campbell@citrix.com> Organization: Oracle Corporation X-Mailer: Claws Mail 3.7.6 (GTK+ 2.18.9; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Source-IP: ucsinet22.oracle.com [156.151.31.94] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1437 Lines: 40 > > #ifndef HYPERVISOR_VIRT_START > diff --git a/include/xen/interface/memory.h > b/include/xen/interface/memory.h index ad0dff5..5de2b36 100644 > --- a/include/xen/interface/memory.h > +++ b/include/xen/interface/memory.h > @@ -188,6 +188,24 @@ DEFINE_GUEST_HANDLE_STRUCT(xen_add_to_physmap); > /*** REMOVED ***/ > /*#define XENMEM_translate_gpfn_list 8*/ > > +#define XENMEM_add_to_physmap_range 23 > +struct xen_add_to_physmap_range { > + /* Which domain to change the mapping for. */ > + domid_t domid; > + uint16_t space; /* => enum phys_map_space */ > + > + /* Number of pages to go through */ > + uint16_t size; > + domid_t foreign_domid; /* IFF gmfn_foreign */ > + > + /* Indexes into space being mapped. */ > + GUEST_HANDLE(xen_ulong_t) idxs; > + > + /* GPFN in domid where the source mapping page should appear. */ > + GUEST_HANDLE(xen_pfn_t) gpfns; Looking at your arm implementation in xen, doesn't look like you are expecting idxs and gpfns to be contigous. In that case, shouldn't idxs and gpfns be pointers, ie, they are sent down as arrays? Or does GUEST_HANDLE do that, I can't seem to find where it's defined quickly. thanks Mukesh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/