Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758917Ab2JYASa (ORCPT ); Wed, 24 Oct 2012 20:18:30 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:40191 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758852Ab2JYAS2 (ORCPT ); Wed, 24 Oct 2012 20:18:28 -0400 Date: Wed, 24 Oct 2012 17:18:23 -0700 From: Joel Becker To: Marco Stornelli Cc: Linux FS Devel , Mark Fasheh , ocfs2-devel@oss.oracle.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 06/21] ocfs2: drop vmtruncate Message-ID: <20121025001822.GC3140@localhost> Mail-Followup-To: Marco Stornelli , Linux FS Devel , Mark Fasheh , ocfs2-devel@oss.oracle.com, linux-kernel@vger.kernel.org References: <508296B4.60508@gmail.com> <20121023085448.GM5635@localhost> <20121023090232.GA13027@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Burt-Line: Trees are cool. X-Red-Smith: Ninety feet between bases is perhaps as close as man has ever come to perfection. User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1794 Lines: 56 On Tue, Oct 23, 2012 at 02:48:38PM +0200, Marco Stornelli wrote: > 2012/10/23 Joel Becker : > > On Tue, Oct 23, 2012 at 10:58:42AM +0200, Marco Stornelli wrote: > >> 2012/10/23 Joel Becker : > >> > On Sat, Oct 20, 2012 at 02:19:00PM +0200, Marco Stornelli wrote: > >> >> Removed vmtruncate > >> >> > >> >> Signed-off-by: Marco Stornelli > >> > > >> > Acked-by: Joel Becker > >> > > >> > Do you want me to pull this, or are you going to send it with your set? > >> > > >> > Joel > >> > > >> > >> I'd prefer to push all via Al's tree since there is a VFS change. > > > > SGTM. Thanks! > > > > Joel > > > > I've got a doubt and I ask to ocfs2 expert :) It seems i_size_write() > and truncate_inode_pages() and so on, they are already called in each > path of setattr for a size change, so maybe we can remove > truncate_setsize() and simply to remove the vmtuncate code, can you > give me your opinion? Actually, I have to revisit this, because Chrisoph points out your adjusting i_size outside of a transaction. Joel > Thanks. > > Marco > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- "Practice random acts of kindness and senseless acts of beauty." Oh, and don't forget where your towel is. http://www.jlbec.org/ jlbec@evilplan.org -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/