Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756181Ab2JYF3u (ORCPT ); Thu, 25 Oct 2012 01:29:50 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:60187 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752947Ab2JYF3t (ORCPT ); Thu, 25 Oct 2012 01:29:49 -0400 Message-id: <5088CE41.7030704@samsung.com> Date: Thu, 25 Oct 2012 07:29:37 +0200 From: Marek Szyprowski User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:16.0) Gecko/20121010 Thunderbird/16.0.1 MIME-version: 1.0 To: Gregory CLEMENT Cc: Jason Cooper , Andrew Lunn , linux-arm-kernel@lists.infradead.org, Arnd Bergmann , Olof Johansson , Ben Dooks , Ian Molton , Nicolas Pitre , Lior Amsalem , Maen Suleiman , Tawfik Bayouk , Shadi Ammouri , Eran Ben-Avi , Yehuda Yitschak , Nadav Haklai , Ike Pan , Jani Monoses , Chris Van Hoof , Dan Frazier , Thomas Petazzoni , Leif Lindholm , Jon Masters , David Marlin , Sebastian Hesselbarth , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] arm: mvebu: increase atomic coherent pool size for armada 370/XP References: <1351086561-13569-1-git-send-email-gregory.clement@free-electrons.com> <1351086561-13569-2-git-send-email-gregory.clement@free-electrons.com> In-reply-to: <1351086561-13569-2-git-send-email-gregory.clement@free-electrons.com> Content-type: text/plain; charset=ISO-8859-2; format=flowed Content-transfer-encoding: 7bit X-TM-AS-MML: No Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2334 Lines: 67 Hello, On 10/24/2012 3:49 PM, Gregory CLEMENT wrote: > For Armada 370/XP we have the same problem that for the commit > cb01b63, so we applied the same solution: "The default 256 KiB > coherent pool may be too small for some of the Kirkwood devices, so > increase it to make sure that devices will be able to allocate their > buffers with GFP_ATOMIC flag" > > Signed-off-by: Gregory CLEMENT > > Cc: Marek Szyprowski Acked-by: Marek Szyprowski > --- > arch/arm/mach-mvebu/armada-370-xp.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/arch/arm/mach-mvebu/armada-370-xp.c b/arch/arm/mach-mvebu/armada-370-xp.c > index 2af6ce5..cbad821 100644 > --- a/arch/arm/mach-mvebu/armada-370-xp.c > +++ b/arch/arm/mach-mvebu/armada-370-xp.c > @@ -17,6 +17,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -43,6 +44,16 @@ void __init armada_370_xp_timer_and_clk_init(void) > armada_370_xp_timer_init(); > } > > +void __init armada_370_xp_init_early(void) > +{ > + /* > + * Some Armada 370/XP devices allocate their coherent buffers > + * from atomic context. Increase size of atomic coherent pool > + * to make sure such the allocations won't fail. > + */ > + init_dma_coherent_pool_size(SZ_1M); > +} > + > struct sys_timer armada_370_xp_timer = { > .init = armada_370_xp_timer_and_clk_init, > }; > @@ -61,6 +72,7 @@ static const char * const armada_370_xp_dt_board_dt_compat[] = { > DT_MACHINE_START(ARMADA_XP_DT, "Marvell Aramada 370/XP (Device Tree)") > .init_machine = armada_370_xp_dt_init, > .map_io = armada_370_xp_map_io, > + .init_early = armada_370_xp_init_early, > .init_irq = armada_370_xp_init_irq, > .handle_irq = armada_370_xp_handle_irq, > .timer = &armada_370_xp_timer, > Best regards -- Marek Szyprowski Samsung Poland R&D Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/