Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758743Ab2JYHrF (ORCPT ); Thu, 25 Oct 2012 03:47:05 -0400 Received: from smtp.eu.citrix.com ([62.200.22.115]:62845 "EHLO SMTP.EU.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755469Ab2JYHrD (ORCPT ); Thu, 25 Oct 2012 03:47:03 -0400 X-IronPort-AV: E=Sophos;i="4.80,646,1344211200"; d="scan'208";a="15374970" Message-ID: <1351151219.18035.94.camel@zakaz.uk.xensource.com> Subject: Re: [Xen-devel] [PATCH 4/5] xen: arm: implement remap interfaces needed for privcmd mappings. From: Ian Campbell To: Mukesh Rathor CC: xen-devel , Stefano Stabellini , linux-kernel , Konrad Rzeszutek Wilk Date: Thu, 25 Oct 2012 08:46:59 +0100 In-Reply-To: <20121024170746.7c89a790@mantra.us.oracle.com> References: <1351084756.18035.28.camel@zakaz.uk.xensource.com> <1351084777-28898-4-git-send-email-ian.campbell@citrix.com> <20121024164411.5b000087@mantra.us.oracle.com> <20121024170746.7c89a790@mantra.us.oracle.com> Organization: Citrix Systems, Inc. Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.4.3-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2060 Lines: 58 On Thu, 2012-10-25 at 01:07 +0100, Mukesh Rathor wrote: > On Wed, 24 Oct 2012 16:44:11 -0700 > Mukesh Rathor wrote: > > > > > > > #ifndef HYPERVISOR_VIRT_START > > > diff --git a/include/xen/interface/memory.h > > > b/include/xen/interface/memory.h index ad0dff5..5de2b36 100644 > > > --- a/include/xen/interface/memory.h > > > +++ b/include/xen/interface/memory.h > > > @@ -188,6 +188,24 @@ DEFINE_GUEST_HANDLE_STRUCT(xen_add_to_physmap); > > > /*** REMOVED ***/ > > > /*#define XENMEM_translate_gpfn_list 8*/ > > > > > > +#define XENMEM_add_to_physmap_range 23 > > > +struct xen_add_to_physmap_range { > > > + /* Which domain to change the mapping for. */ > > > + domid_t domid; > > > + uint16_t space; /* => enum phys_map_space */ > > > + > > > + /* Number of pages to go through */ > > > + uint16_t size; > > > + domid_t foreign_domid; /* IFF gmfn_foreign */ > > > + > > > + /* Indexes into space being mapped. */ > > > + GUEST_HANDLE(xen_ulong_t) idxs; > > > + > > > + /* GPFN in domid where the source mapping page should appear. > > > */ > > > + GUEST_HANDLE(xen_pfn_t) gpfns; > > > > > > Looking at your arm implementation in xen, doesn't look like you are > > expecting idxs and gpfns to be contigous. In that case, shouldn't idxs > > and gpfns be pointers, ie, they are sent down as arrays? Or does > > GUEST_HANDLE do that, I can't seem to find where it's defined quickly. > > Never mind, I see it got corrected to XEN_GUEST_HANDLE in staging tree. The macro is called XEN_GUEST_HANDLE in Xen and just GUEST_HANDLE in Linux. > Still doesn't compile tho: > > public/memory.h:246: error: expected specifier-qualifier-list before > ‘__guest_handle_xen_ulong_t’ > > I'll figure it out. Looks like you've got it all sorted? Ian. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/