From: Jaegeuk Kim <jaegeuk.kim@samsung.com>
To: "'Greg KH'" <gregkh@linuxfoundation.org>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        viro@zeniv.linux.org.uk, arnd@arndb.de, tytso@mit.edu,
        chur.lee@samsung.com, cm224.lee@samsung.com,
        jooyoung.hwang@samsung.com
References: <001001cdb0c5$2ac96520$805c2f60$%kim@samsung.com>
 <20121023182055.GA6096@kroah.com> <20121023191135.GA1623@kroah.com>
In-reply-to: <20121023191135.GA1623@kroah.com>
Subject: RE: [PATCH 0/3] f2fs: move proc files to debugfs
Date: Thu, 25 Oct 2012 17:12:41 +0900
Message-id: <005f01cdb288$8189a3b0$849ceb10$%kim@samsung.com>
MIME-version: 1.0
Content-type: text/plain; charset=windows-1252
Content-transfer-encoding: 7bit
Thread-index: Ac2xUjlGF5puENIXQ/y2iIjoG/kVDwBHw1Ag
Content-language: en-us
DLP-Filter: Pass
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2277
Lines: 58

> On Tue, Oct 23, 2012 at 11:20:55AM -0700, Greg KH wrote:
> > Here are 3 patches, moving the proc file usage on f2fs to debugfs.
> >
> > The first one fixes a bug in the gc.h file preventing it from being able
> > to be included by any other files.
> >
> > The second patch moves all current proc file accesses to a single file,
> > removing all #ifdefs from the .c files.  This should have been done in
> > the first place.
> >
> > The last file converts the files to use debugfs instead of proc.
> >
> > Note, these patches have been compile tested only, I haven't tested them
> > out, as I haven't had the chance to yet.  I'll go do that this afternoon
> > after I catch up on some other pending kernel work.
> >
> > One question, it seems that the proc files show all information for all
> > super blocks in the system, no matter which subdirectory you are reading
> > from in the proc f2fs tree.  Is that really what you want?  Shouldn't we
> > only be showing the stats of the superblock we are saying we will
> > report?  I'll test that later today, and if it really is wrong, will fix
> > the debugfs code up to handle this properly.
> 
> I just tested your patch set, and it looks like I see all partition
> information in each file, no matter what subdir it is in.
> 
> So, do you want this to be broken up per partition/superblock, in a
> subdir, like you intended?  Or just 3 files, for all superblocks in the
> system?

Thank you for great patches. I really appreciate that.
When I merged your patches, I found some unnecessary codes and memory
structures such as gc_info in the original codes.
So I've done some works additionally based on the patches.
Furthermore, for readability, I merged 3 stat files into one file, and
let it show all the superblocks together, no breakdown per partition.
I'll submit v3-series applying these changes soon.
Thanks,

> 
> Oh, the third patch is buggy, don't apply it, I got the subdir logic
> wrong, I'll go fix that up now.
> 
> thanks,
> 
> greg k-h


---
Jaegeuk Kim
Samsung


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/