Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935441Ab2JYJtT (ORCPT ); Thu, 25 Oct 2012 05:49:19 -0400 Received: from mail.skyhub.de ([78.46.96.112]:36255 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934884Ab2JYJtS (ORCPT ); Thu, 25 Oct 2012 05:49:18 -0400 Date: Thu, 25 Oct 2012 11:49:14 +0200 From: Borislav Petkov To: Ivan Hu Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, alex.shi@intel.com, borislav.petkov@amd.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86, intel, power: Modify the MSR_IA32_ENERGY_PERF_BIAS message from warning to info Message-ID: <20121025094914.GA17169@liondog.tnic> Mail-Followup-To: Borislav Petkov , Ivan Hu , tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, alex.shi@intel.com, borislav.petkov@amd.com, linux-kernel@vger.kernel.org References: <1351157280-9935-1-git-send-email-ivan.hu@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1351157280-9935-1-git-send-email-ivan.hu@canonical.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1618 Lines: 42 On Thu, Oct 25, 2012 at 05:28:00PM +0800, Ivan Hu wrote: > Intel IA32 program guild doesn't mention that this MSR should be set by > BIOS, instead, it mentions "Software can use whatever criteria it sees > fit to program the MSR with the appropriate value.". Discuss with IBV, > they'd like to keep this MSR as default, and let OS to change value if desired. > This message should be more proper set as an info than a warning. What is the difference? It'll appear in default dmesg loglevel settings anyway. > Signed-off-by: Ivan Hu > --- > arch/x86/kernel/cpu/intel.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/kernel/cpu/intel.c b/arch/x86/kernel/cpu/intel.c > index 198e019..2bdc6bf 100644 > --- a/arch/x86/kernel/cpu/intel.c > +++ b/arch/x86/kernel/cpu/intel.c > @@ -466,7 +466,7 @@ static void __cpuinit init_intel(struct cpuinfo_x86 *c) > > rdmsrl(MSR_IA32_ENERGY_PERF_BIAS, epb); > if ((epb & 0xF) == ENERGY_PERF_BIAS_PERFORMANCE) { > - printk_once(KERN_WARNING "ENERGY_PERF_BIAS:" > + printk_once(KERN_INFO "ENERGY_PERF_BIAS:" While you're at it, you can do pr_info_once to shorten this line a bit. > " Set to 'normal', was 'performance'\n" > "ENERGY_PERF_BIAS: View and update with" > " x86_energy_perf_policy(8)\n"); > -- > 1.7.10.4 -- Regards/Gruss, Boris. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/