Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759294Ab2JYKpi (ORCPT ); Thu, 25 Oct 2012 06:45:38 -0400 Received: from mail-ie0-f174.google.com ([209.85.223.174]:37722 "EHLO mail-ie0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757452Ab2JYKpg (ORCPT ); Thu, 25 Oct 2012 06:45:36 -0400 MIME-Version: 1.0 In-Reply-To: References: <1350387889-15324-1-git-send-email-hongbo.zhang@linaro.com> <1351079900-32236-1-git-send-email-hongbo.zhang@linaro.com> <1351079900-32236-6-git-send-email-hongbo.zhang@linaro.com> Date: Thu, 25 Oct 2012 18:45:35 +0800 Message-ID: Subject: Re: [PATCH V2 5/6] Thermal: Add ST-Ericsson DB8500 thermal dirver. From: Hongbo Zhang To: Viresh Kumar Cc: Amit Kucheria , linaro-dev@lists.linaro.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, STEricsson_nomadik_linux@list.st.com, kernel@igloocommunity.org, linaro-kernel@lists.linaro.org, "hongbo.zhang" , patches@linaro.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1284 Lines: 36 On 25 October 2012 18:11, Viresh Kumar wrote: > On 25 October 2012 15:34, Viresh Kumar wrote: >> On 25 October 2012 15:26, Hongbo Zhang wrote: > > This is what your prcmu driver's routines are doing: > > int db8500_prcmu_config_hotmon(u8 low, u8 high) > { > ... > wait_for_completion(&mb4_transfer.work); > ... > return 0; > } > > This is why others in STE have used threaded_irqs... Because the > routine you guys call from interrupt handlers actually sleeps. > I should find this for you, but you find it for me :( Thanks a lot. > So, they can't be called from interrupt context. > > I wanted you to knew this :) > > Its okay now, you need to use threaded irq only and you can't use > normal request_irq(). Its not that you want to make things fast that's why > you used threaded irqs... If you try to sleep from interrupt context > (i.e. if you > have registered your handler with request_irq()), you will see a kernel crash. > > -- > viresh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/