Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1945900Ab2JYLZu (ORCPT ); Thu, 25 Oct 2012 07:25:50 -0400 Received: from mga05.intel.com ([192.55.52.89]:10325 "EHLO fmsmga101.fm.intel.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933816Ab2JYLZs (ORCPT ); Thu, 25 Oct 2012 07:25:48 -0400 MIME-Version: 1.0 In-Reply-To: <3908561D78D1C84285E8C5FCA982C28F19D58DE9@ORSMSX108.amr.corp.intel.com> References: <1351000104-13015-1-git-send-email-irina.tirdea@intel.com> <1351000104-13015-3-git-send-email-irina.tirdea@intel.com> <3908561D78D1C84285E8C5FCA982C28F19D58DE9@ORSMSX108.amr.corp.intel.com> From: "Tatulea, Dragos" Date: Thu, 25 Oct 2012 14:25:26 +0300 Message-ID: Subject: Re: [PATCH 02/26] pstore: add flags To: "Luck, Tony" Cc: Kees Cook , "Tirdea, Irina" , Anton Vorontsov , Colin Cross , Chris Ball , "linux-kernel@vger.kernel.org" , "Hunter, Adrian" , "Purdila, Octavian" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 957 Lines: 21 On Tue, Oct 23, 2012 at 7:57 PM, Luck, Tony wrote: >> I wonder if the default should be to not show headers, and to add this >> flag to the backends that want the pstore-added header. I think the >> more common case going forward will to be without headers since >> backends should arguably storing metadata themselves. > > Perhaps just add the headings when pstore breaks a dump into > pieces because of a back-end size limitation. I.e. if there is only > one piece, then no headings. If there are two or more, include > a heading to aid with putting the pieces together later. > But how do you determine the kmsg data size without doing a kmsg_dump_get_buffer beforehand? Thanks, Dragos -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/