Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S935724Ab2JYNx0 (ORCPT <rfc822;w@1wt.eu>);
	Thu, 25 Oct 2012 09:53:26 -0400
Received: from mail-wi0-f178.google.com ([209.85.212.178]:35549 "EHLO
	mail-wi0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S933157Ab2JYNxZ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 25 Oct 2012 09:53:25 -0400
MIME-Version: 1.0
In-Reply-To: <1351089746-5552-1-git-send-email-peter.senna@gmail.com>
References: <1351089746-5552-1-git-send-email-peter.senna@gmail.com>
Date: Thu, 25 Oct 2012 09:53:23 -0400
Message-ID: <CADnq5_MTs65Pn_oCZCpxx5J_Lkdu9rnSJtaLFiNgbp_HLN+_4g@mail.gmail.com>
Subject: Re: [PATCH] drivers/gpu/drm/radeon/evergreen_cs.c: Remove unnecessary semicolon
From: Alex Deucher <alexdeucher@gmail.com>
To: Peter Senna Tschudin <peter.senna@gmail.com>
Cc: airlied@linux.ie, kernel-janitors@vger.kernel.org,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
        jglisse@redhat.com, alexander.deucher@amd.com, airlied@redhat.com
Content-Type: text/plain; charset=ISO-8859-1
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1975
Lines: 64

On Wed, Oct 24, 2012 at 10:42 AM, Peter Senna Tschudin
<peter.senna@gmail.com> wrote:
> A simplified version of the semantic match that finds this problem is as
> follows: (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @r1@
> statement S;
> position p,p1;
> @@
> S@p1;@p
>
> @script:python r2@
> p << r1.p;
> p1 << r1.p1;
> @@
> if p[0].line != p1[0].line_end:
>         cocci.include_match(False)
> @@
> position r1.p;
> @@
> -;@p
> // </smpl>
>
> Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>

Thanks!  I've added this to my patch queue.

Alex

>
> ---
>
> The full version of the semantic patch can be found at:
> http://www.mail-archive.com/cocci@systeme.lip6.fr/msg00014.html
>
>  drivers/gpu/drm/radeon/evergreen_cs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/radeon/evergreen_cs.c b/drivers/gpu/drm/radeon/evergreen_cs.c
> index 573ed1b..5daf0c5 100644
> --- a/drivers/gpu/drm/radeon/evergreen_cs.c
> +++ b/drivers/gpu/drm/radeon/evergreen_cs.c
> @@ -264,7 +264,7 @@ static int evergreen_surface_check_2d(struct radeon_cs_parser *p,
>         /* macro tile width & height */
>         palign = (8 * surf->bankw * track->npipes) * surf->mtilea;
>         halign = (8 * surf->bankh * surf->nbanks) / surf->mtilea;
> -       mtileb = (palign / 8) * (halign / 8) * tileb;;
> +       mtileb = (palign / 8) * (halign / 8) * tileb;
>         mtile_pr = surf->nbx / palign;
>         mtile_ps = (mtile_pr * surf->nby) / halign;
>         surf->layer_size = mtile_ps * mtileb * slice_pt;
> --
> 1.7.11.7
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/