Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760041Ab2JYSMz (ORCPT ); Thu, 25 Oct 2012 14:12:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:28714 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758601Ab2JYSMy (ORCPT ); Thu, 25 Oct 2012 14:12:54 -0400 Date: Thu, 25 Oct 2012 14:12:48 -0400 From: Aristeu Rozanski To: Tejun Heo Cc: linux-kernel@vger.kernel.org, Li Zefan , Al Viro , linux-fsdevel@vger.kernel.org, Hugh Dickins Subject: Re: [PATCH] fs: xattr: rewrite simple_xattr_set() Message-ID: <20121025181248.GH14085@redhat.com> References: <20121025152613.GF14085@redhat.com> <20121025173326.GH11442@htj.dyndns.org> <20121025175412.GG14085@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 665 Lines: 21 On Thu, Oct 25, 2012 at 10:59:35AM -0700, Tejun Heo wrote: > On Thu, Oct 25, 2012 at 10:54 AM, Aristeu Rozanski wrote: > >> So, it returns 0 on success and 1 on failure, which in itself isn't a > >> particularly good idea. > > > > you mean it should return -ENODATA instead? > > Yeap, this is a bug, right? We end up passing that 1 to the set_xattr caller. yes, will resubmit Thanks! -- Aristeu -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/