Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760299Ab2JYUvY (ORCPT ); Thu, 25 Oct 2012 16:51:24 -0400 Received: from usindpps05.hds.com ([207.126.252.18]:34260 "EHLO usindpps05.hds.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759812Ab2JYUvU convert rfc822-to-8bit (ORCPT ); Thu, 25 Oct 2012 16:51:20 -0400 From: Seiji Aguchi To: Mike Waychison CC: "linux-kernel@vger.kernel.org" , "linux-efi@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "Luck, Tony (tony.luck@intel.com)" , "Matthew Garrett (mjg@redhat.com)" , "dzickus@redhat.com" , "dle-develop@lists.sourceforge.net" , Satoru Moriya Subject: RE: [PATCH v2 3/5] efi_pstore: Remove a logic erasing entries from a write callback to hold multiple logs Thread-Topic: [PATCH v2 3/5] efi_pstore: Remove a logic erasing entries from a write callback to hold multiple logs Thread-Index: Ac2yU45Umwbisi8ERWqdMazeX7tkNwAs24eAAAdb8lD//9btAIAAP3Sw Date: Thu, 25 Oct 2012 20:51:06 +0000 Message-ID: References: In-Reply-To: Accept-Language: ja-JP, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.74.43.113] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.7.7855,1.0.431,0.0.0000 definitions=2012-10-25_04:2012-10-25,2012-10-25,1970-01-01 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_policy_notspam policy=outbound_policy score=0 spamscore=0 ipscore=0 suspectscore=1 phishscore=0 bulkscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=6.0.2-1203120001 definitions=main-1210250266 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1465 Lines: 34 > So doesn't this break erasing of existing dumps in pstore-efivars? > Unless efi_pstore_read still understands the older variable name formats, users will be stranded with dumps consuming space in > efivars that aren't exported via pstore anymore. Patch 2/5, 3/5 and 4/5 don't change an existing format of a variable name and don't break anything. The existing format consists of type, id and ctime. And it is not moditied by these patches. Here is a variable name (and guid) of efi_pstore in curret linus-tree. ls /sys/firmware/efi/vars/ dump-type0-1-1351113059-cfc8fc79-be2e-4ddc-97f0-9f98bfe298a0 dump-type0-2-1351113059-cfc8fc79-be2e-4ddc-97f0-9f98bfe298a0 dump-type0-3-1351113059-cfc8fc79-be2e-4ddc-97f0-9f98bfe298a0 Variable Name: dump-type0-1-1351113059 GUID: cfc8fc79-be2e-4ddc-97f0-9f98bfe298a0 On the other hand, patch 5/5 changes the format by adding sequence counter. But efi_pstore_read is modied to work correctly in it. dump-type0-1-1-1351113059-cfc8fc79-be2e-4ddc-97f0-9f98bfe298a0 Variable Name: dump-type0-1-1-1351113059 GUID: cfc8fc79-be2e-4ddc-97f0-9f98bfe298a0 If I need to elaborate more, please feel free to ask me:) I'm not sure if I understand your question completely. Seiji -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/