Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755043Ab2JZALa (ORCPT ); Thu, 25 Oct 2012 20:11:30 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:59897 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754867Ab2JZAL0 (ORCPT ); Thu, 25 Oct 2012 20:11:26 -0400 Date: Thu, 25 Oct 2012 17:11:19 -0700 From: Jonathan Nieder To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, alan@lxorguk.ukuu.org.uk, Fengguang Wu , Kees Cook , Linus Torvalds Subject: Re: [ 08/31] use clamp_t in UNAME26 fix Message-ID: <20121026001119.GA3028@elie.Belkin> References: <20121026000214.941721299@linuxfoundation.org> <20121026000215.817875317@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20121026000215.817875317@linuxfoundation.org> User-Agent: Mutt/1.5.21+51 (9e756d1adb76) (2011-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1289 Lines: 34 Hi, Greg Kroah-Hartman wrote: > commit 31fd84b95eb211d5db460a1dda85e004800a7b52 upstream. > > The min/max call needed to have explicit types on some architectures > (e.g. mn10300). Use clamp_t instead to avoid the warning: > > kernel/sys.c: In function 'override_release': > kernel/sys.c:1287:10: warning: comparison of distinct pointer types lacks a cast [enabled by default] > > Reported-by: Fengguang Wu > Signed-off-by: Kees Cook > Signed-off-by: Linus Torvalds > Signed-off-by: Greg Kroah-Hartman [...] > --- a/kernel/sys.c > +++ b/kernel/sys.c > @@ -1152,7 +1152,7 @@ static int override_release(char __user > rest++; > } > v = ((LINUX_VERSION_CODE >> 8) & 0xff) + 40; > - copy = min(sizeof(buf), max_t(size_t, 1, len)); > + copy = clamp_t(size_t, len, 1, sizeof(buf)); > copy = scnprintf(buf, copy, "2.6.%u%s", v, rest); Does this have any effect at runtime? If not, why is it needed for stable kernels? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/