Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755859Ab2JZDIN (ORCPT <rfc822;w@1wt.eu>);
	Thu, 25 Oct 2012 23:08:13 -0400
Received: from mail-ie0-f174.google.com ([209.85.223.174]:60282 "EHLO
	mail-ie0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755795Ab2JZDIL (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 25 Oct 2012 23:08:11 -0400
Message-ID: <5089FE8E.4030603@gmail.com>
Date: Fri, 26 Oct 2012 11:07:58 +0800
From: Ni zhan Chen <nizhan.chen@gmail.com>
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:16.0) Gecko/20121011 Thunderbird/16.0.1
MIME-Version: 1.0
To: Johannes Weiner <hannes@cmpxchg.org>
CC: Will Deacon <will.deacon@arm.com>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
        mhocko@suse.cz, peterz@infradead.org, akpm@linux-foundation.org,
        Chris Metcalf <cmetcalf@tilera.com>,
        "Kirill A. Shutemov" <kirill@shutemov.name>,
        Andrea Arcangeli <aarcange@redhat.com>
Subject: Re: [PATCH v3] mm: thp: Set the accessed flag for old pages on access
 fault.
References: <1351183471-14710-1-git-send-email-will.deacon@arm.com> <20121025195110.GA4771@cmpxchg.org>
In-Reply-To: <20121025195110.GA4771@cmpxchg.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2160
Lines: 47

On 10/26/2012 03:51 AM, Johannes Weiner wrote:
> On Thu, Oct 25, 2012 at 05:44:31PM +0100, Will Deacon wrote:
>> On x86 memory accesses to pages without the ACCESSED flag set result in the
>> ACCESSED flag being set automatically. With the ARM architecture a page access
>> fault is raised instead (and it will continue to be raised until the ACCESSED
>> flag is set for the appropriate PTE/PMD).
>>
>> For normal memory pages, handle_pte_fault will call pte_mkyoung (effectively
>> setting the ACCESSED flag). For transparent huge pages, pmd_mkyoung will only
>> be called for a write fault.
>>
>> This patch ensures that faults on transparent hugepages which do not result
>> in a CoW update the access flags for the faulting pmd.
>>
>> Cc: Chris Metcalf <cmetcalf@tilera.com>
>> Cc: Kirill A. Shutemov <kirill@shutemov.name>
>> Cc: Andrea Arcangeli <aarcange@redhat.com>
>> Signed-off-by: Will Deacon <will.deacon@arm.com>
> Acked-by: Johannes Weiner <hannes@cmpxchg.org>
>
>> Ok chaps, I rebased this thing onto today's next (which basically
>> necessitated a rewrite) so I've reluctantly dropped my acks and kindly
>> ask if you could eyeball the new code, especially where the locking is
>> concerned. In the numa code (do_huge_pmd_prot_none), Peter checks again
>> that the page is not splitting, but I can't see why that is required.
> I don't either.  If the thing was splitting when the fault happened,
> that path is not taken.  And the locked pmd_same() check should rule
> out splitting setting in after testing pmd_trans_huge_splitting().

Why I can't find function pmd_trans_huge_splitting() you mentioned in 
latest mainline codes and linux-next?

>
> Peter?
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/