Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755872Ab2JZDMV (ORCPT ); Thu, 25 Oct 2012 23:12:21 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:60170 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755671Ab2JZDMU (ORCPT ); Thu, 25 Oct 2012 23:12:20 -0400 MIME-Version: 1.0 In-Reply-To: References: <1351212379-26026-1-git-send-email-ming.lei@canonical.com> Date: Fri, 26 Oct 2012 11:12:18 +0800 Message-ID: Subject: Re: [PATCH v1] firmware loader: introduce module parameter to customize fw search path From: Ming Lei To: Linus Torvalds Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 997 Lines: 31 On Fri, Oct 26, 2012 at 10:32 AM, Linus Torvalds wrote: > > Please just make "fw_path[0]" just be the pointer to fw_path_para[] > (which sounds like the cleanest fix) and get rid of the negative 'i' > and conditional entirely. Yes, it should be the cleanest, I don't do it because I thought that might have caused one compile warning('const char *' points to memory without 'const', like below) static char fw_path_para[256]; static const char *fw_path[] = { fw_path_para, "/lib/firmware/updates/" UTS_RELEASE, "/lib/firmware/updates", "/lib/firmware/" UTS_RELEASE, "/lib/firmware" }; but in fact there isn't any warning with above change and it does work, still don't know why? :-( Thanks, -- Ming Lei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/