Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757777Ab2JZI7m (ORCPT ); Fri, 26 Oct 2012 04:59:42 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:49056 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757534Ab2JZI7j (ORCPT ); Fri, 26 Oct 2012 04:59:39 -0400 Date: Fri, 26 Oct 2012 10:59:34 +0200 From: Sascha Hauer To: Roland Stigge Cc: kernel@pengutronix.de, linux@arm.linux.org.uk, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] ARM: mach-imx: CAN clock fix for i.MX53 Message-ID: <20121026085934.GA1641@pengutronix.de> References: <1351164400-27940-1-git-send-email-stigge@antcom.de> <1351164400-27940-2-git-send-email-stigge@antcom.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1351164400-27940-2-git-send-email-stigge@antcom.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 10:57:51 up 125 days, 9 min, 65 users, load average: 0.35, 0.58, 1.05 User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: 2001:6f8:1178:2:21e:67ff:fe11:9c5c X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2051 Lines: 43 On Thu, Oct 25, 2012 at 01:26:40PM +0200, Roland Stigge wrote: > This patch fixes CAN clocking on i.MX53. > > Signed-off-by: Roland Stigge > > --- > arch/arm/mach-imx/clk-imx51-imx53.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > --- linux-2.6.orig/arch/arm/mach-imx/clk-imx51-imx53.c > +++ linux-2.6/arch/arm/mach-imx/clk-imx51-imx53.c > @@ -426,10 +426,10 @@ int __init mx53_clocks_init(unsigned lon > clk[usb_phy2_gate] = imx_clk_gate2("usb_phy2_gate", "usb_phy_sel", MXC_CCM_CCGR4, 12); > clk[can_sel] = imx_clk_mux("can_sel", MXC_CCM_CSCMR2, 6, 2, > mx53_can_sel, ARRAY_SIZE(mx53_can_sel)); > - clk[can1_serial_gate] = imx_clk_gate2("can1_serial_gate", "can_sel", MXC_CCM_CCGR6, 22); > - clk[can1_ipg_gate] = imx_clk_gate2("can1_ipg_gate", "ipg", MXC_CCM_CCGR6, 20); > - clk[can2_serial_gate] = imx_clk_gate2("can2_serial_gate", "can_sel", MXC_CCM_CCGR4, 8); > - clk[can2_ipg_gate] = imx_clk_gate2("can2_ipg_gate", "ipg", MXC_CCM_CCGR4, 6); I just rechecked. The above matches the i.MX53 Reference Manual rev 2.1 > + clk[can1_serial_gate] = imx_clk_gate2("can1_serial_gate", "can_sel", MXC_CCM_CCGR4, 6); > + clk[can1_ipg_gate] = imx_clk_gate2("can1_ipg_gate", "ipg", MXC_CCM_CCGR4, 8); > + clk[can2_serial_gate] = imx_clk_gate2("can2_serial_gate", "can_sel", MXC_CCM_CCGR4, 6); > + clk[can2_ipg_gate] = imx_clk_gate2("can2_ipg_gate", "ipg", MXC_CCM_CCGR4, 8); This doesn't. Can you elaborate why you think this is necessary? Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/