Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757821Ab2JZJC3 (ORCPT ); Fri, 26 Oct 2012 05:02:29 -0400 Received: from casper.infradead.org ([85.118.1.10]:39464 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754442Ab2JZJC1 (ORCPT ); Fri, 26 Oct 2012 05:02:27 -0400 Subject: Re: [PATCH V3 2/3] dmaengine: dw_dmac: Enhance device tree support From: Vinod Koul To: Viresh Kumar Cc: vinod.koul@intel.com, linux-kernel@vger.kernel.org, spear-devel@list.st.com, andriy.shevchenko@linux.intel.com, linux-arm-kernel@lists.infradead.org, devicetree-discuss@lists.ozlabs.org In-Reply-To: References: <3100e691db3f94c22afd98b609a1568d7e70dfe7.1350360935.git.viresh.kumar@linaro.org> <169edae67b9a051ca7448e5b62c3cd2c5c1db470.1350360935.git.viresh.kumar@linaro.org> Content-Type: text/plain; charset="UTF-8" Date: Fri, 26 Oct 2012 14:18:35 +0530 Message-ID: <1351241315.7077.16.camel@vkoul-udesk3> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1449 Lines: 35 On Fri, 2012-10-26 at 14:25 +0530, Viresh Kumar wrote: > Hi Vinod, > > On 16 October 2012 09:49, Viresh Kumar wrote: > > dw_dmac driver already supports device tree but it used to have its platform > > data passed the non-DT way. > > > > This patch does following changes: > > - pass platform data via DT, non-DT way still takes precedence if both are used. > > - create generic filter routine > > - Earlier slave information was made available by slave specific filter routines > > in chan->private field. Now, this information would be passed from within dmac > > DT node. Slave drivers would now be required to pass bus_id (a string) as > > parameter to this generic filter(), which would be compared against the slave > > data passed from DT, by the generic filter routine. > > - Update binding document > > I can see that you applied these patches and they are present in > linux-next. But i feel > the order of patches is bad. Yes looks like I forgot to sort the mbox series :( since all patches were applied nicely, and they seem fairly independent of each other it should cause issue. Let me know if you wnat me to redo my -next. -- Vinod Koul Intel Corp. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/