Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932535Ab2JZMCJ (ORCPT ); Fri, 26 Oct 2012 08:02:09 -0400 Received: from nat28.tlf.novell.com ([130.57.49.28]:53726 "EHLO nat28.tlf.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753964Ab2JZMCI convert rfc822-to-8bit (ORCPT ); Fri, 26 Oct 2012 08:02:08 -0400 Message-Id: <508A89CB020000780008E6ED@nat28.tlf.novell.com> X-Mailer: Novell GroupWise Internet Agent 12.0.0 Date: Fri, 26 Oct 2012 13:02:03 +0100 From: "Jan Beulich" To: Cc: , , Subject: RE: [Xen-devel] [PATCH 1/2] Xen acpi pad implement References: <5089676602000078000A4928@nat28.tlf.novell.com> In-Reply-To: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8BIT Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1168 Lines: 28 >>> "Liu, Jinsong" 10/26/12 8:18 AM >>> >> +static struct acpi_driver xen_acpi_pad_driver = { >> + .name = "processor_aggregator", >> + .class = ACPI_PROCESSOR_AGGREGATOR_CLASS, >> + .ids = pad_device_ids, >> + .ops = { >> + .add = xen_acpi_pad_add, > >.remove? > >[Jinsong] .remove method not used by any logic now (any possible point use it?), so we remove it from our former patch. Unless there is technical difficulty implementing it, I wouldn't defer adding that code until the point where something doesn't work anymore. >Overall I'd recommend taking a look at the cleaned up driver in >our kernels. > >[Jinsong] What's your point here? There's quite a bit of cleanup/simplification potential here, and rather than pointing the pieces out individually I would think comparing with what we have in production use might be worthwhile. But that's up to you of course. Jan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/