Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932830Ab2JZNOv (ORCPT ); Fri, 26 Oct 2012 09:14:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58101 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758660Ab2JZNOs (ORCPT ); Fri, 26 Oct 2012 09:14:48 -0400 Date: Fri, 26 Oct 2012 11:14:41 -0200 From: Carlos Maiolino To: Abhijit Pawar Cc: linux-fsdevel@vger.kernel.org, "linux-btrfs@vger.kernel.org" , linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org Subject: Re: [RESEND PATCH] fs/super.c set_anon_super calling optimization Message-ID: <20121026131441.GA22256@andromeda.usersys.redhat.com> Mail-Followup-To: Abhijit Pawar , linux-fsdevel@vger.kernel.org, "linux-btrfs@vger.kernel.org" , linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org References: <508924AB.4060902@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <508924AB.4060902@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 755 Lines: 22 Hi, On Thu, Oct 25, 2012 at 05:08:19PM +0530, Abhijit Pawar wrote: > Hi, > set_anon_super is called by many filesystems. Some call directly and > some call through the wrapper. Many of them in the wrapper's call to > this function are passing the second argument to this function which > is not used anywhere. > > This patch replaces the second variable with NULL. > If the variable isn't used anymore, why don't just get rid of it, instead of call the function passing a NULL pointer on it? -- --Carlos -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/