Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933554Ab2JZOtP (ORCPT ); Fri, 26 Oct 2012 10:49:15 -0400 Received: from mail-qa0-f53.google.com ([209.85.216.53]:55949 "EHLO mail-qa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932078Ab2JZOtN (ORCPT ); Fri, 26 Oct 2012 10:49:13 -0400 MIME-Version: 1.0 In-Reply-To: <1351205220.6851.3.camel@lorien2> References: <1351205220.6851.3.camel@lorien2> From: Catalin Marinas Date: Fri, 26 Oct 2012 15:48:52 +0100 X-Google-Sender-Auth: 2szWHQbKRmeBDOv2Siblr6d4U2U Message-ID: Subject: Re: [PATCH RFT] ARM64: dma-mapping: support debug_dma_mapping_error To: shuah.khan@hp.com Cc: tony@atomide.com, olof@lixom.net, santosh.shilimkar@ti.com, nico@linaro.org, LKML , linux-arm-kernel@lists.infradead.org, shuahkhan@gmail.com Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1490 Lines: 35 On 25 October 2012 23:47, Shuah Khan wrote: > Add support for debug_dma_mapping_error() call to avoid warning from > debug_dma_unmap() interface when it checks for mapping error checked > status. Without this patch, device driver failed to check map error > warning is generated. > > Signed-off-by: Shuah Khan > --- > arch/arm64/include/asm/dma-mapping.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/include/asm/dma-mapping.h b/arch/arm64/include/asm/dma-mapping.h > index 538f4b4..9947768 100644 > --- a/arch/arm64/include/asm/dma-mapping.h > +++ b/arch/arm64/include/asm/dma-mapping.h > @@ -50,6 +50,7 @@ static inline phys_addr_t dma_to_phys(struct device *dev, dma_addr_t dev_addr) > static inline int dma_mapping_error(struct device *dev, dma_addr_t dev_addr) > { > struct dma_map_ops *ops = get_dma_ops(dev); > + debug_dma_mapping_error(dev, dev_addr); > return ops->mapping_error(dev, dev_addr); > } The patch looks fine but debug_dma_mapping_error() is not in mainline yet, so it will have to wait. If you want to add it to your series (which I assume adds debug_dma_mapping_error() support), you can add my Acked-by on the patch. -- Catalin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/