Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965030Ab2JZP5d (ORCPT ); Fri, 26 Oct 2012 11:57:33 -0400 Received: from mail-ee0-f46.google.com ([74.125.83.46]:40889 "EHLO mail-ee0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964824Ab2JZP5c (ORCPT ); Fri, 26 Oct 2012 11:57:32 -0400 Message-ID: <508AB2E8.3090601@monstr.eu> Date: Fri, 26 Oct 2012 17:57:28 +0200 From: Michal Simek Reply-To: monstr@monstr.eu User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120827 Thunderbird/15.0 MIME-Version: 1.0 To: shuah.khan@hp.com CC: kyungmin.park@samsung.com, m.szyprowski@samsung.com, arnd@arndb.de, andrzej.p@samsung.com, microblaze-uclinux@itee.uq.edu.au, LKML , shuahkhan@gmail.com Subject: Re: [PATCH RFT] microblaze: dma-mapping: support debug_dma_mapping_error References: <1351207747.6851.15.camel@lorien2> <508A49D3.2080303@monstr.eu> <1351263531.2712.3.camel@lorien2> In-Reply-To: <1351263531.2712.3.camel@lorien2> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2523 Lines: 65 On 10/26/2012 04:58 PM, Shuah Khan wrote: > On Fri, 2012-10-26 at 10:29 +0200, Michal Simek wrote: >> On 10/26/2012 01:29 AM, Shuah Khan wrote: >>> Add support for debug_dma_mapping_error() call to avoid warning from >>> debug_dma_unmap() interface when it checks for mapping error checked >>> status. Without this patch, device driver failed to check map error >>> warning is generated. >>> >>> Signed-off-by: Shuah Khan >>> --- >>> arch/microblaze/include/asm/dma-mapping.h | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/arch/microblaze/include/asm/dma-mapping.h b/arch/microblaze/include/asm/dma-mapping.h >>> index 01d2282..4451c7a 100644 >>> --- a/arch/microblaze/include/asm/dma-mapping.h >>> +++ b/arch/microblaze/include/asm/dma-mapping.h >>> @@ -114,6 +114,7 @@ static inline void __dma_sync(unsigned long paddr, >>> static inline int dma_mapping_error(struct device *dev, dma_addr_t dma_addr) >>> { >>> struct dma_map_ops *ops = get_dma_ops(dev); >> >> here should be empty line. >> >>> + debug_dma_mapping_error(dev, dma_addr); >>> if (ops->mapping_error) >>> return ops->mapping_error(dev, dma_addr); >> >> Patch looks good to me. I was greping the latest mainline tree and I can't see >> reference to debug_dma_mapping_error. Can you tell me where this function >> is implemented. >> I have also seen that you have sent several similar patches like this. >> >> If you want to add it through any other tree here is my ACK: >> >> Acked-by: Michal Simek >> >> I will definitely keep my eyes on it. > > debug_dma_mapping_error() patch is in linux-next. I probably should send > all of these patches marked explicitly for linux-next. Ok. It means that this patch should be added to the tree which contains this patch. You can find it out through linux-next. What it is interesting to me is that arm tree has it there but implementation is missing in Linus tree. [linux-2.6.x]$ grep -rn "debug_dma_mapping_erro" arch/ arch/arm/include/asm/dma-mapping.h:94: debug_dma_mapping_error(dev, dma_addr); Thanks, Michal -- Michal Simek, Ing. (M.Eng) w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/ Microblaze U-BOOT custodian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/