Return-Path: <linux-kernel-owner+willy=40w.ods.org@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id <S317898AbSIEQ0J>; Thu, 5 Sep 2002 12:26:09 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org
	id <S317931AbSIEQ0J>; Thu, 5 Sep 2002 12:26:09 -0400
Received: from dsl-213-023-039-222.arcor-ip.net ([213.23.39.222]:6567 "EHLO
	starship") by vger.kernel.org with ESMTP id <S317898AbSIEQ0I>;
	Thu, 5 Sep 2002 12:26:08 -0400
Content-Type: text/plain; charset=US-ASCII
From: Daniel Phillips <phillips@arcor.de>
To: "Christian Ehrhardt" <ehrhardt@mathematik.uni-ulm.de>
Subject: Re: [RFC] Alternative raceless page free
Date: Thu, 5 Sep 2002 18:10:48 +0200
X-Mailer: KMail [version 1.3.2]
Cc: Andrew Morton <akpm@zip.com.au>, Linus Torvalds <torvalds@transmeta.com>,
       Marcelo Tosatti <marcelo@conectiva.com.br>,
       linux-kernel@vger.kernel.org, Christian Ehrhardt <ulcae@in-ulm.de>
References: <3D644C70.6D100EA5@zip.com.au> <E17myRo-00068H-00@starship> <20020905160431.1671.qmail@thales.mathematik.uni-ulm.de>
In-Reply-To: <20020905160431.1671.qmail@thales.mathematik.uni-ulm.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 7BIT
Message-Id: <E17mzDV-00068Z-00@starship>
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1475
Lines: 31

On Thursday 05 September 2002 18:04, Christian Ehrhardt wrote:
> On Thu, Sep 05, 2002 at 05:21:31PM +0200, Daniel Phillips wrote:
> > On Thursday 05 September 2002 14:34, Christian Ehrhardt wrote:
> > > @@ -455,7 +458,7 @@
> > >                         } else {
> > >                                 /* failed to drop the buffers so stop here */
> > >                                 UnlockPage(page);
> > > -                               page_cache_release(page);
> > > +                               put_page(page);
> > > 
> > >                                 spin_lock(&pagemap_lru_lock);
> > >                                 continue;
> > > 
> > > looks a bit suspicious. put_page is not allowed if the page is still
> > > on the lru and there is no other reference to it. As we don't hold any
> > > locks between UnlockPage and put_page there is no formal guarantee that
> > > the above condition is met. I don't have another path that could race
> > > with this one though and chances are that there actually is none.
> > 
> > The corresponding get_page is just above, you must have overlooked it.

I misspoke.  You're right, page_cache_release is the appropriate function
here, not put_page.  Fixed, thanks.

-- 
Daniel
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/