Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Thu, 5 Sep 2002 12:47:04 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Thu, 5 Sep 2002 12:47:04 -0400 Received: from dsl-213-023-039-222.arcor-ip.net ([213.23.39.222]:21671 "EHLO starship") by vger.kernel.org with ESMTP id ; Thu, 5 Sep 2002 12:47:04 -0400 Content-Type: text/plain; charset=US-ASCII From: Daniel Phillips To: "Christian Ehrhardt" Subject: Re: [RFC] Alternative raceless page free Date: Thu, 5 Sep 2002 18:31:45 +0200 X-Mailer: KMail [version 1.3.2] Cc: Andrew Morton , Linus Torvalds , Marcelo Tosatti , linux-kernel@vger.kernel.org, Christian Ehrhardt References: <3D644C70.6D100EA5@zip.com.au> <20020905160431.1671.qmail@thales.mathematik.uni-ulm.de> In-Reply-To: <20020905160431.1671.qmail@thales.mathematik.uni-ulm.de> MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Message-Id: Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 932 Lines: 21 On Thursday 05 September 2002 18:04, Christian Ehrhardt wrote: > On Thu, Sep 05, 2002 at 05:21:31PM +0200, Daniel Phillips wrote: > > ...this particular piece of code can no doubt be considerably > > simplified, while improving robustness and efficiency at the same time. > > But that goes beyond the scope of this patch. > > Well yes ;-) There's funny things going on like accessing a page > after page_cache_release... You're right about that one too, it should be put_page_nofree, since freeing the page there is a bug for two reasons: !!page->mapping tells us there should be a count on the page, and we continue to operate on the page immediately below. Thanks again. -- Daniel - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/