Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758914Ab2J0PGH (ORCPT ); Sat, 27 Oct 2012 11:06:07 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:57952 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756083Ab2J0PGD (ORCPT ); Sat, 27 Oct 2012 11:06:03 -0400 Date: Sat, 27 Oct 2012 08:06:49 -0700 From: Greg KH To: Yan Hong Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/5] debugfs: remove goto in debugfs_remount() Message-ID: <20121027150649.GC3349@kroah.com> References: <1351325129-10097-1-git-send-email-clouds.yan@gmail.com> <1351325129-10097-5-git-send-email-clouds.yan@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1351325129-10097-5-git-send-email-clouds.yan@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 425 Lines: 12 On Sat, Oct 27, 2012 at 04:05:29PM +0800, Yan Hong wrote: > Simple code clean to remove goto. There is nothing wrong with gotos on error paths, so this one should stay. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/