Date: Sat, 27 Oct 2012 17:45:49 +0200
From: Alessandro Rubini <rubini@gnudd.com>
To: gregkh@linuxfoundation.org
Cc: clouds.yan@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] debugfs: pass NULL as the last parameter of
 debugfs_print_regs32()
Message-ID: <20121027154549.GA7132@mail.gnudd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Organization: GnuDD, Device Drivers, Embedded Systems, Courses
In-Reply-To: <20121027150715.GD3349@kroah.com>
References: <20121027150715.GD3349@kroah.com>
  <1351325129-10097-1-git-send-email-clouds.yan@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1016
Lines: 22

>> This function is only used (twice) by the author of it, and the
>> 'prefix' feature is never used.

I introduced it to shrink some internal code that had a lot of
repetition in the debugfs files implementation. In that context I use
the prefix string.  Some of the code had later been submitted, but not
yet all of it.  Later work by Davide Ciminaghi moved our MFD user to
the regmap interface, according to maintainer's suggestion (which
however means loosing register names from the debugfs dump).

> If the parameter isn't being used, please, just delete it.

It is not currently used by upstream callers, but the function itself
uses it as documented (Documentation/...).  I wouldn't remove the
feature and introduce an incompatibility just for this.

/alessandro
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/