Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759287Ab2J0QTH (ORCPT ); Sat, 27 Oct 2012 12:19:07 -0400 Received: from mail-vc0-f174.google.com ([209.85.220.174]:46168 "EHLO mail-vc0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756488Ab2J0QTE (ORCPT ); Sat, 27 Oct 2012 12:19:04 -0400 MIME-Version: 1.0 In-Reply-To: <20121027150649.GC3349@kroah.com> References: <1351325129-10097-1-git-send-email-clouds.yan@gmail.com> <1351325129-10097-5-git-send-email-clouds.yan@gmail.com> <20121027150649.GC3349@kroah.com> Date: Sun, 28 Oct 2012 00:19:04 +0800 Message-ID: Subject: Re: [PATCH 5/5] debugfs: remove goto in debugfs_remount() From: Yan Hong To: Greg KH Cc: linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 728 Lines: 20 2012/10/27 Greg KH : > On Sat, Oct 27, 2012 at 04:05:29PM +0800, Yan Hong wrote: >> Simple code clean to remove goto. > > There is nothing wrong with gotos on error paths, so this one should > stay. > > greg k-h I thought we use goto on error path because there is no other elegant ways to do the things, but it sounds like goto is still welcome and preferable when we are not in this case. Anyway, this is a simple clean, I do not insist on it. Thanks -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/