Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753989Ab2J0Xrs (ORCPT ); Sat, 27 Oct 2012 19:47:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:16871 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751840Ab2J0Xrr (ORCPT ); Sat, 27 Oct 2012 19:47:47 -0400 Date: Sun, 28 Oct 2012 01:47:28 +0200 From: Jiri Olsa To: Stephane Eranian Cc: LKML , Peter Zijlstra , "mingo@elte.hu" , Namhyung Kim Subject: Re: [BUG] perf parser: does not support arbitrary new sysfs events Message-ID: <20121027234728.GA22073@krava.redhat.com> References: <20121027203427.GB9099@krava.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1504 Lines: 36 On Sun, Oct 28, 2012 at 01:13:59AM +0200, Stephane Eranian wrote: > On Sat, Oct 27, 2012 at 10:34 PM, Jiri Olsa wrote: > > On Fri, Oct 26, 2012 at 10:23:09PM +0200, Stephane Eranian wrote: > >> Hi, > >> > >> The latest round of perf parser changes broke my PEBS-LL patch series > >> (at the last minute). For PEBS-LL, I need to add to generic events but I want > >> to keep them PMU specific. As such, they need to live in the sysfs events > >> subdir: /sys/devices/cpu/events/mem-loads, sys/devices/cpu/events/mem-stores. > >> > >> Given your latest rounds of sysfs event changes, I had to modify my kernel > >> patches to fit those two new events within your perf_pmu_events_attr tables. > >> > >> But now, when I try to do: > >> > >> $ perf record -e cpu/mem-loads/ .... > > > > I can try this only on on uncore events and hw events aliases and that seems to work > > > I know it works there. I don't understand why it does not work with cpu/. > > Just add an encoding that has no hardcoded equivalent. I bet you will > reproduce the problem. > > In my patch set, I have extended your perf_pmu_events_attr struct to > also accept an already preformed event_str. I can send you that extension > if you want. that would be great jirka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/